All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Tomas Henzl <thenzl@redhat.com>
Cc: linux-scsi@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH] scsi_logging: fix a BUG
Date: Thu, 24 Mar 2022 07:13:48 -0700	[thread overview]
Message-ID: <Yjx8nJSI0cK+s3LA@infradead.org> (raw)
In-Reply-To: <20220324134603.28463-1-thenzl@redhat.com>

On Thu, Mar 24, 2022 at 02:46:03PM +0100, Tomas Henzl wrote:
> The request_queue may be NULL in a request, for example when it comes
> from scsi_ioctl_reset.
> Check it before before use.
> 
> Fixes: f3fa33acca9f ("block: remove the ->rq_disk field in struct request")
> 
> Reported-by: Changhui Zhong <czhong@redhat.com>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>

As a quick fix this look good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

but I really wonder if we should print some other identifier if the disk
name is not available.

  reply	other threads:[~2022-03-24 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24 13:46 [PATCH] scsi_logging: fix a BUG Tomas Henzl
2022-03-24 14:13 ` Christoph Hellwig [this message]
2022-03-30  3:29 ` Martin K. Petersen
2022-04-07 13:35 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yjx8nJSI0cK+s3LA@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.