Re: [PATCH v2] sctp: Initialize daddr on peeled off socket

From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Petr Malat <oss@malat.biz>
Cc: linux-sctp@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2] sctp: Initialize daddr on peeled off socket
Date: Fri, 8 Apr 2022 14:34:05 -0300	[thread overview]
Message-ID: <YlByDe3YttU5K8dU@t14s.localdomain> (raw)
In-Reply-To: <20220307220220.652293-1-oss@malat.biz>

On Mon, Mar 07, 2022 at 11:02:21PM +0100, Petr Malat wrote:
> Function sctp_do_peeloff() wrongly initializes daddr of the original
> socket instead of the peeled off socket, which makes getpeername()
> return zeroes instead of the primary address. Initialize the new socket
> instead.
> 
> Fixes: d570ee490fb1 ("[SCTP]: Correctly set daddr for IPv6 sockets during peeloff")
> Signed-off-by: Petr Malat <oss@malat.biz>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

You need to re-post it to netdev@, btw, but please feel free to carry
the tag above on it.

> ---
>  net/sctp/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 3e1a9600be5e..7b0427658056 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -5636,7 +5636,7 @@ int sctp_do_peeloff(struct sock *sk, sctp_assoc_t id, struct socket **sockp)
>  	 * Set the daddr and initialize id to something more random and also
>  	 * copy over any ip options.
>  	 */
> -	sp->pf->to_sk_daddr(&asoc->peer.primary_addr, sk);
> +	sp->pf->to_sk_daddr(&asoc->peer.primary_addr, sock->sk);
>  	sp->pf->copy_ip_options(sk, sock->sk);
>  
>  	/* Populate the fields of the newsk from the oldsk and migrate the
> -- 
> 2.30.2
> 