From: Vinod Koul <vkoul@kernel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8450: fix interconnects property of UFS node
Date: Tue, 12 Apr 2022 16:47:43 +0530 [thread overview]
Message-ID: <YlVf13E+AI4JAgkp@matsya> (raw)
In-Reply-To: <2af9a8a7-0904-df31-7c1a-21705bcda8d6@linaro.org>
On 12-04-22, 09:34, Vladimir Zapolskiy wrote:
> Hi Bjorn,
>
> On 4/12/22 05:35, Bjorn Andersson wrote:
> > On Tue 05 Apr 12:38 CDT 2022, Dmitry Baryshkov wrote:
> >
> > > On Tue, 5 Apr 2022 at 20:17, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> > > >
> > > > On Tue 05 Apr 08:38 PDT 2022, Dmitry Baryshkov wrote:
> > > >
> > > > > On 11/03/2022 01:19, Vladimir Zapolskiy wrote:
> > > > > > All interconnect device tree nodes on sm8450 are 2-cells, however in
> > > > > > UFS node they are handled as 1-cells, fix it.
> > > > > >
> > > > > > Fixes: aa2d0bf04a3c ("arm64: dts: qcom: sm8450: add interconnect nodes")
> > > > > > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> > > > >
> > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > > >
> > > > > Bjorn, could you please this pick for the -rc kernel?
> > > > >
> > > >
> > > > The change is obviously correct, but what difference does this change
> > > > make with the current implementation?
> > >
> > > it makes interconnect paths probe correctly. All NoC have
> > > #interconnec-cells = <2> now.
> > >
> >
> > But there's no code in the UFS driver that calls of_icc_get(), so what
> > does this actually do? (Other than correcting the dtb for the day when
> > we add that support to the driver).
>
> FWIW the change also has a runtime effect, it fixes a parsing of the board dtb,
> otherwise a warning in the kernel log appears:
>
> OF: /soc@0/ufshc@1d84000: could not get #interconnect-cells for /clocks/sleep-clk
>
> Why /clocks/sleep-clk is mentioned here at all??
> Its phandle value is 0x26, which is equal to SLAVE_UFS_MEM_CFG from the array.
We should either apply this fix or a patch to drop this line from dts.
Either would be apt and latter would make more sense..
--
~Vinod
next prev parent reply other threads:[~2022-04-12 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 22:19 [PATCH] arm64: dts: qcom: sm8450: fix interconnects property of UFS node Vladimir Zapolskiy
2022-03-11 4:55 ` Vinod Koul
2022-04-05 15:38 ` Dmitry Baryshkov
2022-04-05 17:19 ` Bjorn Andersson
2022-04-05 17:38 ` Dmitry Baryshkov
2022-04-12 2:35 ` Bjorn Andersson
2022-04-12 6:34 ` Vladimir Zapolskiy
2022-04-12 11:17 ` Vinod Koul [this message]
2022-06-06 15:57 ` Dmitry Baryshkov
2022-06-27 20:03 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlVf13E+AI4JAgkp@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.