From: Christoph Hellwig <hch@infradead.org>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/5] xfs_quota: split get_quota() and report_mount()/dump_file()
Date: Wed, 13 Apr 2022 08:54:44 -0700 [thread overview]
Message-ID: <YlbyRFlTZa18mIgB@infradead.org> (raw)
In-Reply-To: <Yk7F0CM+DKf2wEYA@aalbersh.remote.csb>
On Thu, Apr 07, 2022 at 01:06:56PM +0200, Andrey Albershteyn wrote:
> I did it like this initially but it appeared to me that the diff was
> messy. As there were many &d -> d and report_mount ->
> get_quota/report_mount replacements, so I split it. But I'm not
> against reshaping this back, should I do it?
Well, a large part of this series is churn and we can't do much about
it. To me doing the changes together seems more logical, but in the
end either way is fine, so feel free to do it the way you prefer.
next prev parent reply other threads:[~2022-04-13 15:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 22:24 [PATCH 0/5] xfsprogs: optimize -L/-U range calls for xfs_quota's dump/report Andrey Albershteyn
2022-03-28 22:24 ` [PATCH 1/5] xfs_quota: separate quota info acquisition into get_quota() Andrey Albershteyn
2022-03-28 23:44 ` Darrick J. Wong
2022-04-06 16:31 ` Christoph Hellwig
2022-03-28 22:25 ` [PATCH 2/5] xfs_quota: create fs_disk_quota_t on upper level Andrey Albershteyn
2022-04-06 16:34 ` Christoph Hellwig
2022-03-28 22:25 ` [PATCH 3/5] xfs_quota: split get_quota() and report_mount()/dump_file() Andrey Albershteyn
2022-04-06 16:36 ` Christoph Hellwig
2022-04-07 11:06 ` Andrey Albershteyn
2022-04-13 15:54 ` Christoph Hellwig [this message]
2022-03-28 22:25 ` [PATCH 4/5] xfs_quota: utilize XFS_GETNEXTQUOTA for ranged calls in report/dump Andrey Albershteyn
2022-04-06 16:38 ` Christoph Hellwig
2022-03-28 22:25 ` [PATCH 5/5] xfs_quota: apply -L/-U range limits in uid/gid/pid loops Andrey Albershteyn
2022-04-06 16:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlbyRFlTZa18mIgB@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.