From: Eric Biggers <ebiggers@kernel.org>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>
Subject: Re: [RFC 0/6] ext4: Move out crypto ops to ext4_crypto.c
Date: Thu, 21 Apr 2022 00:24:00 -0700 [thread overview]
Message-ID: <YmEGkAQ+T/3EnVHC@sol.localdomain> (raw)
In-Reply-To: <cover.1650517532.git.ritesh.list@gmail.com>
On Thu, Apr 21, 2022 at 10:53:16AM +0530, Ritesh Harjani wrote:
> Hello,
>
> This is 1st in the series to cleanup ext4/super.c, since it has grown quite large.
> This moves out crypto related ops and few definitions to fs/ext4/ext4_crypto.c
>
> Testing
> =========
> 1. Tested "-g encrypt" with default configs.
> 2. Compiled tested on x86 & Power.
>
>
> Ritesh Harjani (6):
> fscrypt: Provide definition of fscrypt_set_test_dummy_encryption
> ext4: Move ext4 crypto code to its own file ext4_crypto.c
> ext4: Directly opencode ext4_set_test_dummy_encryption
> ext4: Cleanup function defs from ext4.h into ext4_crypto.c
> ext4: Move all encryption related into a common #ifdef
> ext4: Use provided macro for checking dummy_enc_policy
>
> fs/ext4/Makefile | 1 +
> fs/ext4/ext4.h | 81 +++--------------
> fs/ext4/ext4_crypto.c | 192 ++++++++++++++++++++++++++++++++++++++++
> fs/ext4/super.c | 158 ++++-----------------------------
> include/linux/fscrypt.h | 7 ++
> 5 files changed, 227 insertions(+), 212 deletions(-)
> create mode 100644 fs/ext4/ext4_crypto.c
How about calling it crypto.c instead of ext4_crypto.c? It is already in the
ext4 directory, so ext4 is implied.
Otherwise this patchset looks good to me.
Did you consider moving any of the other CONFIG_FS_ENCRYPTION code blocks into
the new file as well? The implementation of FS_IOC_GET_ENCRYPTION_PWSALT might
be a good candidate too.
- Eric
next prev parent reply other threads:[~2022-04-21 7:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 5:23 [RFC 0/6] ext4: Move out crypto ops to ext4_crypto.c Ritesh Harjani
2022-04-21 5:23 ` [RFC 1/6] fscrypt: Provide definition of fscrypt_set_test_dummy_encryption Ritesh Harjani
2022-04-21 5:23 ` [RFC 2/6] ext4: Move ext4 crypto code to its own file ext4_crypto.c Ritesh Harjani
2022-04-21 5:23 ` [RFC 3/6] ext4: Directly opencode ext4_set_test_dummy_encryption Ritesh Harjani
2022-04-21 5:23 ` [RFC 4/6] ext4: Cleanup function defs from ext4.h into ext4_crypto.c Ritesh Harjani
2022-04-21 5:23 ` [RFC 5/6] ext4: Move all encryption related into a common #ifdef Ritesh Harjani
2022-04-21 5:23 ` [RFC 6/6] ext4: Use provided macro for checking dummy_enc_policy Ritesh Harjani
2022-04-21 7:24 ` Eric Biggers [this message]
2022-04-21 15:07 ` [RFC 0/6] ext4: Move out crypto ops to ext4_crypto.c Ritesh Harjani
2022-05-01 7:18 ` Eric Biggers
2022-05-02 14:26 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmEGkAQ+T/3EnVHC@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.