From: Matthew Wilcox <willy@infradead.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] mm/mlock: abstract a function to decide whether necessary to drain mlock_pvec
Date: Fri, 22 Apr 2022 03:39:03 +0100 [thread overview]
Message-ID: <YmIVR4DWjBxUF+Eu@casper.infradead.org> (raw)
In-Reply-To: <20220422022059.31181-1-richard.weiyang@gmail.com>
On Fri, Apr 22, 2022 at 02:20:59AM +0000, Wei Yang wrote:
> Just like the function pagevec_add_and_need_flush does, we can abstract
> a function mlock_add_and_need_flush to decide whether it is necessary to
> drain mlock_pvec.
>
> No functional change is expected.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Matthew Wilcox (Oracle) <willy@infradead.org>
> CC: Hugh Dickins <hughd@google.com>
> ---
> mm/mlock.c | 27 +++++++++++++++++++++------
> 1 file changed, 21 insertions(+), 6 deletions(-)
This seems like a needless abstraction to me that makes understanding
the code flow harder, not simpler.
prev parent reply other threads:[~2022-04-22 2:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 2:20 [PATCH] mm/mlock: abstract a function to decide whether necessary to drain mlock_pvec Wei Yang
2022-04-22 2:39 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmIVR4DWjBxUF+Eu@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.