From: Rob Herring <robh@kernel.org>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: netdev@vger.kernel.org, linus.walleij@linaro.org,
alsi@bang-olufsen.dk, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org,
arinc.unal@arinc9.com, devicetree@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] dt-bindings: net: dsa: realtek: cleanup compatible strings
Date: Mon, 25 Apr 2022 13:48:22 -0500 [thread overview]
Message-ID: <Ymbs9ri8JJXTM8XO@robh.at.kernel.org> (raw)
In-Reply-To: <20220418233558.13541-1-luizluca@gmail.com>
On Mon, Apr 18, 2022 at 08:35:57PM -0300, Luiz Angelo Daros de Luca wrote:
> Compatible strings are used to help the driver find the chip ID/version
> register for each chip family. After that, the driver can setup the
> switch accordingly. Keep only the first supported model for each family
> as a compatible string and reference other chip models in the
> description.
The power supplies needing power before you can actually read the ID
registers are the same for all the variations?
The RTL8366s has a serdes power supply while the RTL8370 does not. Maybe
that doesn't matter as the PHYs probably don't need power to access
registers, but I didn't look at more than 2 datasheets. If there's *any*
differences in power sequencing then you need specific compatibles.
Rob
next prev parent reply other threads:[~2022-04-25 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 23:35 [PATCH net v2 1/2] dt-bindings: net: dsa: realtek: cleanup compatible strings Luiz Angelo Daros de Luca
2022-04-18 23:35 ` [PATCH net v2 2/2] net: dsa: realtek: remove realtek,rtl8367s string Luiz Angelo Daros de Luca
2022-04-18 23:48 ` Andrew Lunn
2022-04-19 0:43 ` Arınç ÜNAL
2022-04-18 23:48 ` [PATCH net v2 1/2] dt-bindings: net: dsa: realtek: cleanup compatible strings Andrew Lunn
2022-04-19 0:47 ` Arınç ÜNAL
2022-04-19 13:10 ` Alvin Šipraga
2022-04-19 13:13 ` Alvin Šipraga
2022-04-20 10:10 ` patchwork-bot+netdevbpf
2022-04-20 20:29 ` Luiz Angelo Daros de Luca
2022-04-22 17:56 ` Jakub Kicinski
2022-04-25 18:48 ` Rob Herring [this message]
2022-04-27 21:43 ` Luiz Angelo Daros de Luca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymbs9ri8JJXTM8XO@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.