From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>
Subject: Re: [PATCH v2] dt-bindings: iio: adc: Document Renesas RZ/G2UL ADC
Date: Mon, 2 May 2022 12:04:03 -0500 [thread overview]
Message-ID: <YnAPA9flIrt6qtfB@robh.at.kernel.org> (raw)
In-Reply-To: <20220501191705.19860b69@jic23-huawei>
On Sun, May 01, 2022 at 07:17:05PM +0100, Jonathan Cameron wrote:
> On Sun, 1 May 2022 12:19:52 +0100
> Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> > ADC found on RZ/G2UL SoC is almost identical to RZ/G2L SoC, but RZ/G2UL
> > has 2 analog input channels compared to 8 channels on RZ/G2L. Therefore,
> > added a new compatible to handle this difference.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v1->v2:
> > * Removed Items and used const for RZ/G2UL compatible
> > * Add allOf:if:then restricting available channels per SoC variant.
> > ---
> > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 34 ++++++++++++++-----
> > 1 file changed, 25 insertions(+), 9 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> > index d66c24cae1e1..d76c5ba3d625 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> > @@ -17,11 +17,13 @@ description: |
> >
> > properties:
> > compatible:
> > - items:
> > - - enum:
> > - - renesas,r9a07g044-adc # RZ/G2L
> > - - renesas,r9a07g054-adc # RZ/V2L
> > - - const: renesas,rzg2l-adc
> > + oneOf:
> > + - const: renesas,renesas,r9a07g043-adc # RZ/G2UL
> > + - items:
> > + - enum:
> > + - renesas,r9a07g044-adc # RZ/G2L
> > + - renesas,r9a07g054-adc # RZ/V2L
> > + - const: renesas,rzg2l-adc
> >
> > reg:
> > maxItems: 1
> > @@ -76,10 +78,24 @@ patternProperties:
> > properties:
> > reg:
> > description: |
> > - The channel number. It can have up to 8 channels numbered from 0 to 7.
> > - items:
> > - - minimum: 0
> > - maximum: 7
> > + The channel number. It can have up to 8 channels numbered from 0 to 7
> > + for RZ/{G2L,V2L} SoCs or 2 channels numbered from 0 to 1 for RZ/G2UL
> > + SoC.
> > + allOf:
> > + if:
> - if:
> properties:
> etc
>
> Otherwise I think you can only have one in your allOf: which rather
> removes the point of having one.
>
> I was surprised this passed the checks, so added another if to verify my
> reasoning...
It didn't apply, so checks didn't run. But it should fail not for the
reason you correctly identified, but because 'allOf' is a DT property
here not json-schema vocabulary.
Rob
next prev parent reply other threads:[~2022-05-02 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 11:19 [PATCH v2] dt-bindings: iio: adc: Document Renesas RZ/G2UL ADC Biju Das
2022-05-01 18:17 ` Jonathan Cameron
2022-05-02 17:04 ` Rob Herring [this message]
2022-05-02 4:15 ` Prabhakar Mahadev Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnAPA9flIrt6qtfB@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.