From: Jarkko Sakkinen <jarkko@kernel.org>
To: Johannes Holland <johannes.holland@infineon.com>
Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
peterhuewe@gmx.de, jgg@ziepe.ca,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 3/4] tpm: Implement command and response retry in tpm_tis_core
Date: Sat, 7 May 2022 22:56:49 +0300 [thread overview]
Message-ID: <YnbPAa0LZA3aGiZA@iki.fi> (raw)
In-Reply-To: <20220506170013.22598-3-johannes.holland@infineon.com>
On Fri, May 06, 2022 at 07:00:15PM +0200, Johannes Holland wrote:
> Some errors during command transmission and response reception are
> recoverable. Implement the specified retry mechanisms.
>
> Recoverable errors during response reception:
> * invalid response size during header read
> * left over data:
> a communication error can lead to a FIFO read of 0xFFs and an
> unexpected STS.dataAvail = 1, subsequently
> * CRC mismatch
>
> Recoverable errors during transmit:
> * CRC mismatch
>
> Signed-off-by: Johannes Holland <johannes.holland@infineon.com>
You should split this multiple patch, each implementing one retry
mechanism (CRC's can for recv and transmit can be in a single path
tho):
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes
BR, Jarkko
next prev parent reply other threads:[~2022-05-07 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 17:00 [PATCH v2 1/4] tpm: Add tpm_tis_i2c backend for tpm_tis_core Johannes Holland
2022-05-06 17:00 ` [PATCH v2 2/4] tpm: Add tpm_tis_verify_crc to the tpm_tis_phy_ops protocol layer Johannes Holland
2022-05-07 19:53 ` Jarkko Sakkinen
2022-05-06 17:00 ` [PATCH v2 3/4] tpm: Implement command and response retry in tpm_tis_core Johannes Holland
2022-05-07 19:56 ` Jarkko Sakkinen [this message]
2022-05-06 17:00 ` [PATCH v2 4/4] dt-bindings: doc/devicetree/bindings/security/tpm: Move tpm-i2c.txt to YAML Johannes Holland
2022-05-07 15:58 ` Krzysztof Kozlowski
2022-05-07 16:01 ` [PATCH v2 1/4] tpm: Add tpm_tis_i2c backend for tpm_tis_core Krzysztof Kozlowski
2022-05-07 19:52 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnbPAa0LZA3aGiZA@iki.fi \
--to=jarkko@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jgg@ziepe.ca \
--cc=johannes.holland@infineon.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.