Re: [PATCH] staging: drivers: hid: hid-asus.c: Optimized input logic for keys

From: Johan Boger <jb@ip.fi>
To: Joe Perches <joe@perches.com>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: drivers: hid: hid-asus.c: Optimized input logic for keys
Date: Mon, 9 May 2022 17:06:39 +0200	[thread overview]
Message-ID: <Ynkt/0vIhLFTceXO@debian> (raw)
In-Reply-To: <5e44ef1302b722d3bf7fafe55111e76f7173e6be.camel@perches.com>

On Mon, May 09, 2022 at 06:54:51AM -0700, Joe Perches wrote:
> On Mon, 2022-05-09 at 12:02 +0200, Johan Boger wrote:
> > Instead of calling asus_map_key_clear() function in each case,
> > we now set a temporary value and clear it after default.
> > Patch was checked by checkpatch and adjusted accordingly.
> 
> This patch subject is not correct.  This is not a staging patch.
> 
> Your commit message is also incomplete as this is modifying comments,
> changing whitespace, and changing brace styles.
> 
> and IMO:
> 
> Either use a single line case style like:
> 
> 	case foo: statement; break;
> 
> or use a multiple line case style like:
> 
> 	case foo:
> 		statement;
> 		break;
> 
> but please do not use a mixed case one line and statement; break;
> on another like:
> 
> 	case foo:
> 		statement; break;
> 
> Please remember checkpatch is only a guide, it's not the last word
> on style where every message it emits requires an actual code change.
> 
> btw: there are _many_ single line case uses in the kernel
> 
> $ git grep  -P 'case\s+\w+\s*:\s*\w+' -- '*.[ch]' | wc -l
> 7581
> 
> 
> 
Ok. Thanks for helping me out.
Will resend when I have made sure it's up to standards.

Your time and guidance is appreciated.