From: Luis Chamberlain <mcgrof@kernel.org>
To: Saravana Kannan <saravanak@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
Aaron Tomlin <atomlin@redhat.com>,
cl@linux.com, mbenes@suse.cz, akpm@linux-foundation.org,
jeyu@kernel.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org, void@manifault.com,
atomlin@atomlin.com, allen.lkml@gmail.com, joe@perches.com,
msuchanek@suse.de, oleksandr@natalenko.name,
jason.wessel@windriver.com, pmladek@suse.com,
daniel.thompson@linaro.org, hch@infradead.org,
kernel-team@android.com
Subject: Re: [PATCH v1] module: Fix prefix for module.sig_enforce module param
Date: Thu, 2 Jun 2022 12:16:10 -0700 [thread overview]
Message-ID: <YpkMelZC+E5hKTw6@bombadil.infradead.org> (raw)
In-Reply-To: <20220602035653.4167316-1-saravanak@google.com>
On Wed, Jun 01, 2022 at 08:56:52PM -0700, Saravana Kannan wrote:
> Commit cfc1d277891e ("module: Move all into module/") changed the prefix
> of the module param by moving/renaming files. A later commit also moves
> the module_param() into a different file, thereby changing the prefix
> yet again.
>
> This would break kernel cmdline compatibility and also userspace
> compatibility at /sys/module/module/parameters/sig_enforce.
>
> So, set the prefix back to "module.".
>
> Cc: Aaron Tomlin <atomlin@redhat.com>
> Cc: mcgrof@kernel.org
> Cc: christophe.leroy@csgroup.eu
> Cc: cl@linux.com
> Cc: mbenes@suse.cz
> Cc: akpm@linux-foundation.org
> Cc: jeyu@kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-modules@vger.kernel.org
> Cc: void@manifault.com
> Cc: atomlin@atomlin.com
> Cc: allen.lkml@gmail.com
> Cc: joe@perches.com
> Cc: msuchanek@suse.de
> Cc: oleksandr@natalenko.name
> Cc: jason.wessel@windriver.com
> Cc: pmladek@suse.com
> Cc: daniel.thompson@linaro.org
> Cc: hch@infradead.org
> Fixes: cfc1d277891e ("module: Move all into module/")
> Signed-off-by: Saravana Kannan <saravanak@google.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Linus want to take this in or should I just queueu these up?
Luis
next prev parent reply other threads:[~2022-06-02 19:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 14:03 [PATCH v12 00/14] module: core code clean up Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 01/14] module: Move all into module/ Aaron Tomlin
2022-06-02 3:41 ` Saravana Kannan
2022-06-02 19:14 ` Luis Chamberlain
2022-06-02 3:56 ` [PATCH v1] module: Fix prefix for module.sig_enforce module param Saravana Kannan
2022-06-02 19:16 ` Luis Chamberlain [this message]
2022-06-02 19:40 ` Linus Torvalds
2022-06-02 21:47 ` Saravana Kannan
2022-06-02 22:59 ` Luis Chamberlain
2022-06-03 3:48 ` Saravana Kannan
2022-06-03 4:30 ` Randy Dunlap
2022-06-02 19:35 ` Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 02/14] module: Simple refactor in preparation for split Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 03/14] module: Make internal.h and decompress.c more compliant Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 04/14] module: Move livepatch support to a separate file Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 05/14] module: Move latched RB-tree " Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 06/14] module: Move strict rwx " Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 07/14] module: Move extra signature support out of core code Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 08/14] module: Move kmemleak support to a separate file Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 09/14] module: Move kallsyms support into " Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 10/14] module: kallsyms: Fix suspicious rcu usage Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 11/14] module: Move procfs support into a separate file Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 12/14] module: Move sysfs " Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 13/14] module: Move kdb module related code out of main kdb code Aaron Tomlin
2022-03-22 14:03 ` [PATCH v12 14/14] module: Move version support into a separate file Aaron Tomlin
2022-03-22 15:41 ` [PATCH v12 00/14] module: core code clean up Michal Suchánek
2022-03-22 17:23 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpkMelZC+E5hKTw6@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=atomlin@atomlin.com \
--cc=atomlin@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cl@linux.com \
--cc=daniel.thompson@linaro.org \
--cc=hch@infradead.org \
--cc=jason.wessel@windriver.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=msuchanek@suse.de \
--cc=oleksandr@natalenko.name \
--cc=pmladek@suse.com \
--cc=saravanak@google.com \
--cc=torvalds@linux-foundation.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.