Re: [PATCH v5 1/8] perf record ibs: Warn about sampling period skew

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: namhyung@kernel.org, kan.liang@linux.intel.com, jolsa@kernel.org,
	irogers@google.com, peterz@infradead.org, rrichter@amd.com,
	mingo@redhat.com, mark.rutland@arm.com, tglx@linutronix.de,
	bp@alien8.de, james.clark@arm.com, leo.yan@linaro.org,
	ak@linux.intel.com, eranian@google.com, like.xu.linux@gmail.com,
	x86@kernel.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, sandipan.das@amd.com,
	ananth.narayan@amd.com, kim.phillips@amd.com,
	santosh.shukla@amd.com
Subject: Re: [PATCH v5 1/8] perf record ibs: Warn about sampling period skew
Date: Fri, 3 Jun 2022 21:25:46 +0200	[thread overview]
Message-ID: <YppgOuFXzaTmCsmY@kernel.org> (raw)
In-Reply-To: <76f02f9c-139b-f26b-0cc6-6edc486f5244@amd.com>

Em Fri, Jun 03, 2022 at 10:58:13AM +0530, Ravi Bangoria escreveu:
> On 03-Jun-22 10:42 AM, Ravi Bangoria wrote:
> >>> +       if (ibs_fetch_pmu && ibs_fetch_pmu->type == evsel_pmu->type) {
> >>> +               if (attr->config & (1ULL << 59)) {
> >>
> >> It'd be nice if we used a macro or something instead of the
> >> magic number.
> >>
> >>> +                       ibs_l3miss_warn();
> >>> +                       warned_once = 1;
> >>> +               }
> >>> +       } else if (ibs_op_pmu && ibs_op_pmu->type == evsel_pmu->type) {
> >>> +               if (attr->config & (1ULL << 16)) {
> >>
> >> Ditto.
> > 
> > Thanks for the review, Namhyung.
> > 
> > Arnaldo, Would you be able to squash below trivial patch into original
> > patch? Please let me know if you want me to respin the series instead.
> 
> I'm planning to respin with asprintf() change. Sorry for the noise.

Ok, will wait for the respin then.

- Arnaldo