From: Matthew Wilcox <willy@infradead.org>
To: Nikolay Borisov <nborisov@suse.com>
Cc: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use preallocated page for super block write
Date: Thu, 9 Jun 2022 13:36:09 +0100 [thread overview]
Message-ID: <YqHpOSWedxnjPWfP@casper.infradead.org> (raw)
In-Reply-To: <1c8faef3-6ccb-6eb8-6f42-d52faf8f74e1@suse.com>
On Thu, Jun 09, 2022 at 10:30:06AM +0300, Nikolay Borisov wrote:
> nit: I think it's important to remark in the changelog that with this change
> sb writing becomes sequential as opposed to parallel with the old code. This
> also means that wait_dev_supers can be simplified because the max_mirror's
> loop is not needed, at least for waiting, since for each device we at most
> need to wait for the last write to it, as all previous ones have been
> serialized by the pagelock.
I've just re-read the patch very carefully three times, and I don't
see the change that makes this happen. Can you explain to me how it
happens?
next prev parent reply other threads:[~2022-06-09 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 15:42 [PATCH] btrfs: use preallocated page for super block write David Sterba
2022-06-07 17:06 ` Boris Burkov
2022-06-08 17:49 ` Johannes Thumshirn
2022-06-09 7:30 ` Nikolay Borisov
2022-06-09 12:26 ` David Sterba
2022-06-09 12:36 ` Matthew Wilcox [this message]
2022-06-09 12:37 ` Nikolay Borisov
2022-06-16 14:37 ` [btrfs] 66a7a2412f: xfstests.btrfs.131.fail kernel test robot
2022-06-16 14:37 ` kernel test robot
2022-06-16 21:17 ` Matthew Wilcox
2022-06-16 21:17 ` Matthew Wilcox
2022-06-16 22:00 ` David Sterba
2022-06-16 22:00 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqHpOSWedxnjPWfP@casper.infradead.org \
--to=willy@infradead.org \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.