From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yihao Han <hanyihao@vivo.com>
Cc: Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: phy: tahvo: Check before clk_disable() not needed
Date: Fri, 10 Jun 2022 11:01:04 +0200 [thread overview]
Message-ID: <YqMIUOTU/k5XpW3I@kroah.com> (raw)
In-Reply-To: <20220610074525.69453-1-hanyihao@vivo.com>
On Fri, Jun 10, 2022 at 12:45:25AM -0700, Yihao Han wrote:
> clk_disable() already checks the clk ptr using IS_ERR_OR_NULL(clk)
It does? Are you sure? It will check for NULL, that's it.
> so there is no need to check it again before calling it.
This will break on some platforms, please always test your patches
before sending them out.
thanks,
greg k-h
prev parent reply other threads:[~2022-06-10 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 7:45 [PATCH] usb: phy: tahvo: Check before clk_disable() not needed Yihao Han
2022-06-10 9:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqMIUOTU/k5XpW3I@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=hanyihao@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.