From: Andrew Lunn <andrew@lunn.ch>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ondrej Spacek <ondrej.spacek@nxp.com>
Subject: Re: [PATCH, net] phy: aquantia: Fix AN when higher speeds than 1G are not advertised
Date: Sun, 12 Jun 2022 01:20:49 +0200 [thread overview]
Message-ID: <YqUjUQLOHUo55egO@lunn.ch> (raw)
In-Reply-To: <AM9PR04MB8397DF04A87E32E6B7E690E096A99@AM9PR04MB8397.eurprd04.prod.outlook.com>
On Sat, Jun 11, 2022 at 06:13:12PM +0000, Claudiu Manoil wrote:
> > -----Original Message-----
> > From: Andrew Lunn <andrew@lunn.ch>
> > Sent: Saturday, June 11, 2022 6:00 PM
> [...]
> > Subject: Re: [PATCH, net] phy: aquantia: Fix AN when higher speeds than 1G are
> > not advertised
> >
> > On Fri, Jun 10, 2022 at 11:40:37AM +0300, Claudiu Manoil wrote:
> > > Even when the eth port is resticted to work with speeds not higher than 1G,
> > > and so the eth driver is requesting the phy (via phylink) to advertise up
> > > to 1000BASET support, the aquantia phy device is still advertising for 2.5G
> > > and 5G speeds.
> > > Clear these advertising defaults when requested.
> >
> > Hi Claudiu
> >
> > genphy_c45_an_config_aneg(phydev) is called in aqr_config_aneg, which
> > should set/clear MDIO_AN_10GBT_CTRL_ADV5G and
> > MDIO_AN_10GBT_CTRL_ADV2_5G. Does the aQuantia PHY not have these bits?
> >
>
> Hi Andrew,
>
> Apparently it's not enough to clear the 7.20h register (aka MDIO_AN_10GBT_CTRL)
> to stop AQR advertising for higher speeds, otherwise I wouldn't have bothered with
> the patch.
I'm just trying to ensure we are not papering over a crack. I wanted
to eliminate the possibility of a bug in that code which is changing
7.20h. If the datasheet for the aquantia states those bits are not
used, then this patch is fine. If on the other hand the datasheet says
7.20 can be used to change the advertisement, we should investigate
further what is really going on.
Andrew
next prev parent reply other threads:[~2022-06-11 23:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 8:40 [PATCH, net] phy: aquantia: Fix AN when higher speeds than 1G are not advertised Claudiu Manoil
2022-06-11 14:59 ` Andrew Lunn
2022-06-11 18:13 ` Claudiu Manoil
2022-06-11 23:20 ` Andrew Lunn [this message]
2022-06-12 18:47 ` Claudiu Manoil
2022-06-12 21:25 ` Andrew Lunn
2022-06-14 14:08 ` Claudiu Manoil
2022-06-17 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqUjUQLOHUo55egO@lunn.ch \
--to=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=ondrej.spacek@nxp.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.