From: Greg KH <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: William McVicker <willmcvicker@google.com>,
stable@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
kernel-team@android.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 4.19 v1 1/2] hwmon: Introduce hwmon_device_register_for_thermal
Date: Thu, 30 Jun 2022 08:34:32 +0200 [thread overview]
Message-ID: <Yr1D+BGiv3MXgpm/@kroah.com> (raw)
In-Reply-To: <4bafbfe7-1a9e-651e-41c1-76a131c1a477@roeck-us.net>
On Wed, Jun 29, 2022 at 07:31:10PM -0700, Guenter Roeck wrote:
> On 6/29/22 16:18, William McVicker wrote:
> > On 06/29/2022, Guenter Roeck wrote:
> > > On 6/29/22 15:58, Will McVicker wrote:
> > > > From: Guenter Roeck <linux@roeck-us.net>
> > > >
> > > > [ upstream commit e5d21072054fbadf41cd56062a3a14e447e8c22b ]
> > > >
> > > > The thermal subsystem registers a hwmon driver without providing
> > > > chip or sysfs group information. This is for legacy reasons and
> > > > would be difficult to change. At the same time, we want to enforce
> > > > that chip information is provided when registering a hwmon device
> > > > using hwmon_device_register_with_info(). To enable this, introduce
> > > > a special API for use only by the thermal subsystem.
> > > >
> > > > Acked-by: Rafael J . Wysocki <rafael@kernel.org>
> > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > >
> > > NACK. The patch introducing the problem needs to be reverted.
> >
> > I'm fine with that as well. I've already verified that fixes the issue. I'll go
> > ahead and send the revert.
> >
>
> My understanding is that it is already queued up.
Yes it is, sorry for the delay, will try to push out -rc releases later
today...
greg k-h
next prev parent reply other threads:[~2022-06-30 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 22:58 [PATCH 4.19 v1 0/2] Fixes for thermal hwmon registration Will McVicker
2022-06-29 22:58 ` [PATCH 4.19 v1 1/2] hwmon: Introduce hwmon_device_register_for_thermal Will McVicker
2022-06-29 23:15 ` Guenter Roeck
2022-06-29 23:18 ` William McVicker
2022-06-30 2:31 ` Guenter Roeck
2022-06-30 6:34 ` Greg KH [this message]
2022-06-29 22:58 ` [PATCH 4.19 v1 2/2] thermal/drivers/thermal_hwmon: Use hwmon_device_register_for_thermal() Will McVicker
2022-06-29 23:16 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr1D+BGiv3MXgpm/@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=jdelvare@suse.com \
--cc=kernel-team@android.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.