From: Vinod Koul <vkoul@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: dmaengine@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] dmaengine: imx-sdma: only restart cyclic channel when enabled
Date: Fri, 1 Jul 2022 22:08:20 +0530 [thread overview]
Message-ID: <Yr8i/ILoouWWZHtj@matsya> (raw)
In-Reply-To: <20220617115042.4004062-1-s.hauer@pengutronix.de>
On 17-06-22, 13:50, Sascha Hauer wrote:
> An interrupt for a channel might be pending even after struct
> dma_device::device_terminate_all has been called. In that case the
> recently introduced warning message "restart cyclic channel..." triggers
> and the channel will be restarted. This is not desired as the channel
> has just been stopped. Only restart the channel when we still have a
> descriptor set for it (which will be set to NULL in
> sdma_terminate_all()).
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2022-07-01 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 11:50 [PATCH] dmaengine: imx-sdma: only restart cyclic channel when enabled Sascha Hauer
2022-07-01 16:38 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr8i/ILoouWWZHtj@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.