From: Francois Romieu <romieu@fr.zoreil.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, corbet@lwn.net, jdmason@kudzu.us,
vburru@marvell.com, jiawenwu@trustnetic.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] eth: remove neterion/vxge
Date: Fri, 1 Jul 2022 19:12:43 +0200 [thread overview]
Message-ID: <Yr8rC9jXtoFbUIQ+@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20220701044234.706229-1-kuba@kernel.org>
Jakub Kicinski <kuba@kernel.org> :
> The last meaningful change to this driver was made by Jon in 2011.
> As much as we'd like to believe that this is because the code is
> perfect the chances are nobody is using this hardware.
It was used with some success in 2017:
https://bugzilla.kernel.org/show_bug.cgi?id=197881
> Because of the size of this driver there is a nontrivial maintenance
> cost to keeping this code around, in the last 2 years we're averaging
> more than 1 change a month. Some of which require nontrivial review
> effort, see commit 877fe9d49b74 ("Revert "drivers/net/ethernet/neterion/vxge:
> Fix a use-after-free bug in vxge-main.c"") for example.
vxge_remove() calls vxge_device_unregister().
vxge_device_unregister() does unregister_netdev() + ... + free_netdev().
vxge_remove() keeps using netdev_priv() pointer... :o/
Imho it is not nontrivial enough that top-level maintainers must handle it
but it is just mvho that maintainers handle too much low-value stuff.
Regarding the unused hardware side of the problem, it's a bit sad that
there still is no centralized base of interested users for a given piece
of hardware in 2022.
--
Ueimor
next prev parent reply other threads:[~2022-07-01 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 4:42 [PATCH net-next] eth: remove neterion/vxge Jakub Kicinski
2022-07-01 10:34 ` Jiri Pirko
2022-07-01 13:17 ` David Lamparter
2022-07-01 14:06 ` Jiri Pirko
2022-07-01 14:11 ` David Lamparter
2022-07-01 16:15 ` Jakub Kicinski
2022-07-04 8:24 ` Martin Habets
2022-07-01 17:12 ` Francois Romieu [this message]
2022-07-01 21:40 ` Jakub Kicinski
2022-07-05 6:17 ` Paolo Abeni
2022-07-05 18:06 ` Jakub Kicinski
2022-07-05 18:27 ` Stephen Hemminger
2022-07-06 0:44 ` Francois Romieu
2022-07-05 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr8rC9jXtoFbUIQ+@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdmason@kudzu.us \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.