From: Alexander Gordeev <agordeev@linux.ibm.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, Ilya Leoshkevich <iii@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] s390/purgatory: remove duplicated build rule of kexec-purgatory.o
Date: Wed, 22 Jun 2022 15:48:49 +0200 [thread overview]
Message-ID: <YrMdwXwHE0qLRZLC@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com> (raw)
In-Reply-To: <20220613170902.1775211-3-masahiroy@kernel.org>
On Tue, Jun 14, 2022 at 02:09:02AM +0900, Masahiro Yamada wrote:
> This is equivalent to the pattern rule in scripts/Makefile.build.
>
> Having the dependency on $(obj)/purgatory.ro is enough.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/s390/purgatory/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/purgatory/Makefile b/arch/s390/purgatory/Makefile
> index 3e2c17ba04de..d237bc6841cb 100644
> --- a/arch/s390/purgatory/Makefile
> +++ b/arch/s390/purgatory/Makefile
> @@ -48,7 +48,6 @@ OBJCOPYFLAGS_purgatory.ro += --remove-section='.note.*'
> $(obj)/purgatory.ro: $(obj)/purgatory $(obj)/purgatory.chk FORCE
> $(call if_changed,objcopy)
>
> -$(obj)/kexec-purgatory.o: $(obj)/kexec-purgatory.S $(obj)/purgatory.ro FORCE
> - $(call if_changed_rule,as_o_S)
> +$(obj)/kexec-purgatory.o: $(obj)/purgatory.ro
>
> obj-y += kexec-purgatory.o
Applied, thanks!
> --
> 2.32.0
>
next prev parent reply other threads:[~2022-06-22 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 17:09 [PATCH 1/3] s390: remove unneeded 'select BUILD_BIN2C' Masahiro Yamada
2022-06-13 17:09 ` [PATCH 2/3] s390/purgatory: hard-code obj-y in Makefile Masahiro Yamada
2022-06-22 13:48 ` Alexander Gordeev
2022-06-23 10:08 ` Masahiro Yamada
2022-06-13 17:09 ` [PATCH 3/3] s390/purgatory: remove duplicated build rule of kexec-purgatory.o Masahiro Yamada
2022-06-22 13:48 ` Alexander Gordeev [this message]
2022-06-22 13:39 ` [PATCH 1/3] s390: remove unneeded 'select BUILD_BIN2C' Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrMdwXwHE0qLRZLC@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com \
--to=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.