Re: [PATCH 9/9] xfs: add in-memory iunlink log item

From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 9/9] xfs: add in-memory iunlink log item
Date: Wed, 29 Jun 2022 00:25:53 -0700	[thread overview]
Message-ID: <Yrv+gfvrtIFOwami@infradead.org> (raw)
In-Reply-To: <20220627004336.217366-10-david@fromorbit.com>

On Mon, Jun 27, 2022 at 10:43:36AM +1000, Dave Chinner wrote:
> TO do this, we introduce a new in-memory log item to track the

s/To/To/

> This allows us to pass the xfs_inode to the transaction commit code
> along with the modification to be made, and then order the logged
> modifications via the ->iop_sort and ->iop_precommit operations
> for the new log item type. As this is an in-memory log item, it
> doesn't have formatting, CIL or AIL operational hooks - it exists
> purely to run the inode unlink modifications and is then removed
> from the transaction item list and freed once the precommit
> operation has run.

Do we need to document the fact that we now have purely in-memory log
items better somewhere?  I see how this works, but it its a little
non-obvious.