From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: xor - move __crypto_xor into lib/
Date: Mon, 11 Jul 2022 17:02:09 +0200 [thread overview]
Message-ID: <Ysw7cewDUYp1mgEU@zx2c4.com> (raw)
In-Reply-To: <20220709215453.262237-1-ebiggers@kernel.org>
Hi Eric,
On Sat, Jul 09, 2022 at 02:54:53PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> CRYPTO_LIB_CHACHA depends on CRYPTO for __crypto_xor, defined in
> crypto/algapi.c. This is a layering violation because the dependencies
> should only go in the other direction (crypto/ => lib/crypto/). Also
> the correct dependency would be CRYPTO_ALGAPI, not CRYPTO. Fix this by
> moving __crypto_xor into lib/xor.c, alongside lib/memneq.c where
> __crypto_memneq was recently moved.
>
> Note that CRYPTO_LIB_CHACHA_GENERIC selected XOR_BLOCKS, which is
> unrelated and unnecessary. It was perhaps thought that XOR_BLOCKS was
> needed for __crypto_xor, but that's not the case.
Oh thank goodness. Excellent! Indeed untangling this knot will be a
large improvement.
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Jason
next prev parent reply other threads:[~2022-07-11 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 21:54 [PATCH] crypto: xor - move __crypto_xor into lib/ Eric Biggers
2022-07-11 15:02 ` Jason A. Donenfeld [this message]
2022-07-15 8:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ysw7cewDUYp1mgEU@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.