From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>,
Taehee Yoo <ap420073@gmail.com>,
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Subject: Re: [PATCH] ipv6: fix lockdep splat in in6_dump_addrs()
Date: Thu, 14 Jul 2022 17:46:18 +0300 [thread overview]
Message-ID: <YtAsOlBliPwJG/Q3@kili> (raw)
In-Reply-To: <20220628121248.858695-1-edumazet@google.com>
On Tue, Jun 28, 2022 at 12:12:48PM +0000, Eric Dumazet wrote:
> As reported by syzbot, we should not use rcu_dereference()
> when rcu_read_lock() is not held.
>
Is the comment at the top of the function out of date?
5141 /* called with rcu_read_lock() */
^^^^^^^^^^^^^^^^^^^^^^^^^^^
5142 static int in6_dump_addrs(struct inet6_dev *idev, struct sk_buff *skb,
5143 struct netlink_callback *cb, int s_ip_idx,
5144 struct inet6_fill_args *fillargs)
5145 {
regards,
dan carpenter
prev parent reply other threads:[~2022-07-14 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 12:12 [PATCH] ipv6: fix lockdep splat in in6_dump_addrs() Eric Dumazet
2022-06-30 4:00 ` patchwork-bot+netdevbpf
2022-07-14 14:46 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtAsOlBliPwJG/Q3@kili \
--to=dan.carpenter@oracle.com \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.