From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Patryk Duda <pdk@semihalf.com>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
upstream@semihalf.com
Subject: Re: [PATCH] platform/chrome: cros_ec_proto: Update version on GET_NEXT_EVENT failure
Date: Mon, 18 Jul 2022 03:20:47 +0000 [thread overview]
Message-ID: <YtTRj2MF5/nd94Pe@google.com> (raw)
In-Reply-To: <20220714160951.9364-1-pdk@semihalf.com>
On Thu, Jul 14, 2022 at 06:09:51PM +0200, Patryk Duda wrote:
> @@ -750,6 +750,7 @@ int cros_ec_get_next_event(struct cros_ec_device *ec_dev,
> u8 event_type;
> u32 host_event;
> int ret;
> + u32 ver_mask = 0;
Drop the initialization. Ideally, `ver_mask` wouldn't be touched if `ret` is
less than 0.
next prev parent reply other threads:[~2022-07-18 3:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 16:09 [PATCH] platform/chrome: cros_ec_proto: Update version on GET_NEXT_EVENT failure Patryk Duda
2022-07-14 16:31 ` Guenter Roeck
2022-07-18 3:20 ` Tzung-Bi Shih [this message]
2022-08-02 15:41 ` [PATCH v1] " Patryk Duda
2022-08-04 9:00 ` Tzung-Bi Shih
2022-08-04 10:59 ` Patryk Duda
2022-08-05 2:40 ` patchwork-bot+chrome-platform
2022-08-15 3:44 ` patchwork-bot+chrome-platform
2022-08-15 3:55 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtTRj2MF5/nd94Pe@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdk@semihalf.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.