Re: [Intel-gfx] [PATCH] drm/i915: Pass drm_i915_private struct instead of gt for gen11_gu_misc_irq_handler()

From: Matt Roper <matthew.d.roper@intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Pass drm_i915_private struct instead of gt for gen11_gu_misc_irq_handler()
Date: Mon, 18 Jul 2022 11:54:19 -0700	[thread overview]
Message-ID: <YtWsW+q+soTMtHgi@mdroper-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <20220718183424.149988-1-anusha.srivatsa@intel.com>

On Mon, Jul 18, 2022 at 11:34:24AM -0700, Anusha Srivatsa wrote:
> gen11_gu_misc_irq_handler() does not do anything tile specific.
> 
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_irq.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 73cebc6aa650..c304af777d58 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2669,10 +2669,10 @@ gen11_gu_misc_irq_ack(struct intel_gt *gt, const u32 master_ctl)
>  }
>  
>  static void
> -gen11_gu_misc_irq_handler(struct intel_gt *gt, const u32 iir)
> +gen11_gu_misc_irq_handler(struct drm_i915_private *i915, const u32 iir)
>  {
>  	if (iir & GEN11_GU_MISC_GSE)
> -		intel_opregion_asle_intr(gt->i915);
> +		intel_opregion_asle_intr(i915);
>  }
>  
>  static inline u32 gen11_master_intr_disable(void __iomem * const regs)
> @@ -2740,7 +2740,7 @@ static irqreturn_t gen11_irq_handler(int irq, void *arg)
>  
>  	gen11_master_intr_enable(regs);
>  
> -	gen11_gu_misc_irq_handler(gt, gu_misc_iir);
> +	gen11_gu_misc_irq_handler(i915, gu_misc_iir);
>  
>  	pmu_irq_stats(i915, IRQ_HANDLED);
>  
> @@ -2805,7 +2805,7 @@ static irqreturn_t dg1_irq_handler(int irq, void *arg)
>  
>  	dg1_master_intr_enable(regs);
>  
> -	gen11_gu_misc_irq_handler(gt, gu_misc_iir);
> +	gen11_gu_misc_irq_handler(i915, gu_misc_iir);
>  
>  	pmu_irq_stats(i915, IRQ_HANDLED);
>  
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation