From: Christoph Hellwig <hch@infradead.org>
To: gjoyce@linux.vnet.ibm.com
Cc: linux-block@vger.kernel.org, keyrings@vger.kernel.org,
dhowells@redhat.com, jarkko@kernel.org,
jonathan.derrick@linux.dev, brking@linux.vnet.ibm.com,
greg@gilhooley.com, gjoyce@ibm.com
Subject: Re: [PATCH 1/4] block: sed-opal: Implement IOC_OPAL_DISCOVERY
Date: Wed, 20 Jul 2022 00:42:57 -0700 [thread overview]
Message-ID: <YteyAb4oO36vFzdn@infradead.org> (raw)
In-Reply-To: <20220718210156.1535955-2-gjoyce@linux.vnet.ibm.com>
On Mon, Jul 18, 2022 at 04:01:53PM -0500, gjoyce@linux.vnet.ibm.com wrote:
> + if (discv_out) {
> + buf_out = (u8 __user *)(uintptr_t)discv_out->data;
> + len_out = min(discv_out->size, (u64)hlen);
> + if (buf_out && copy_to_user(buf_out, dev->resp, len_out)) {
> + return -EFAULT;
> + }
No need for the braces here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-07-20 7:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 21:01 [PATCH 0/4] sed-opal: keyrings, discovery, revert and key store gjoyce
2022-07-18 21:01 ` [PATCH 1/4] block: sed-opal: Implement IOC_OPAL_DISCOVERY gjoyce
2022-07-20 7:42 ` Christoph Hellwig [this message]
2022-07-18 21:01 ` [PATCH 2/4] block: sed-opal: Implement IOC_OPAL_REVERT_LSP gjoyce
2022-07-20 7:44 ` Christoph Hellwig
2022-07-18 21:01 ` [PATCH 3/4] block: sed-opal: keyring support for SED Opal keys gjoyce
2022-07-19 6:49 ` Hannes Reinecke
2022-07-20 7:49 ` Christoph Hellwig
2022-07-18 21:01 ` [PATCH 4/4] arch_vars: create arch specific permanent store gjoyce
2022-07-20 7:50 ` Christoph Hellwig
2022-07-26 18:53 ` Greg Joyce
2022-07-28 7:43 ` [PATCH 0/4] sed-opal: keyrings, discovery, revert and key store Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2022-07-06 2:39 gjoyce
2022-07-06 2:39 ` [PATCH 1/4] block: sed-opal: Implement IOC_OPAL_DISCOVERY gjoyce
2022-07-06 8:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YteyAb4oO36vFzdn@infradead.org \
--to=hch@infradead.org \
--cc=brking@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=gjoyce@ibm.com \
--cc=gjoyce@linux.vnet.ibm.com \
--cc=greg@gilhooley.com \
--cc=jarkko@kernel.org \
--cc=jonathan.derrick@linux.dev \
--cc=keyrings@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.