From: Greg KH <gregkh@linuxfoundation.org>
To: Chen Xingdi <chenxingdi@huawei.com>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, chunkeey@googlemail.com
Subject: Re: [PATCH -next] usb: renesas-xhci: Use pr_info while fw verify success
Date: Tue, 26 Jul 2022 18:51:39 +0200 [thread overview]
Message-ID: <YuAbm09hv4ZGXIw5@kroah.com> (raw)
In-Reply-To: <20220726060509.20748-1-chenxingdi@huawei.com>
On Tue, Jul 26, 2022 at 02:05:09PM +0800, Chen Xingdi wrote:
> While fw verify success, it is confused to print an error
> log which is actually not an error, so use pr_info to print
> firmware version instead of pr_err.
>
> Signed-off-by: Chen Xingdi <chenxingdi@huawei.com>
> ---
> drivers/usb/host/xhci-pci-renesas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c
> index 52599d96634f..1eb1d863d545 100644
> --- a/drivers/usb/host/xhci-pci-renesas.c
> +++ b/drivers/usb/host/xhci-pci-renesas.c
> @@ -151,7 +151,7 @@ static int renesas_fw_verify(const void *fw_data,
> }
>
> fw_version = get_unaligned_le16(fw_data + fw_version_pointer);
> - pr_err("got firmware version: %02x.", fw_version);
> + pr_info("got firmware version: %02x.", fw_version);
Why print anything at all? When drivers are working properly, they
should be quiet. Who relies on this message being sent to the kernel
log?
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-26 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 6:05 [PATCH -next] usb: renesas-xhci: Use pr_info while fw verify success Chen Xingdi
2022-07-26 16:51 ` Greg KH [this message]
2022-07-27 2:07 ` 答复: " chenxingdi
2022-07-27 3:11 ` [PATCH v2 -next] usb: renesas-xhci: Do not print any log while fw verif success Chen Xingdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuAbm09hv4ZGXIw5@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chenxingdi@huawei.com \
--cc=chunkeey@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.