Re: [PATCH v2 2/5] dt-bindings: remoteproc: qcom,q6v5: Move MSM8916 to schema

From: Stephan Gerhold <stephan@gerhold.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sireesh Kodali <sireeshkodali1@gmail.com>,
	Luca Weiss <luca@z3ntu.xyz>,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/5] dt-bindings: remoteproc: qcom,q6v5: Move MSM8916 to schema
Date: Tue, 26 Jul 2022 19:19:18 +0200	[thread overview]
Message-ID: <YuAh/ahbNiiQL5Ge@gerhold.net> (raw)
In-Reply-To: <27b0d451-4cef-cfc3-c6ae-3bb6cb448083@linaro.org>

On Sat, Jul 23, 2022 at 10:41:53PM +0200, Krzysztof Kozlowski wrote:
> On 21/07/2022 22:02, Stephan Gerhold wrote:
> > What remains is maybe:
> > 
> >   - "qcom,smem-states", which is already used in several other schemas
> >     and could be possibly defined together with #qcom,smem-state-cells
> >     in some generic schema(?)
> > 
> >   - "qcom,halt-regs", "firmware-name", "smd-edge" are used by different
> >     Qualcomm remoteproc drivers, so they could possibly be defined in
> >     some common "qcom-remoteproc.yaml" schema(?)
> 
> smd-edge and glink is already in remoteproc/qcom,smd-edge.yaml
> qcom,glink-edge.yaml
> 

Yep, I'm actually using it already in this patch. I think what I meant
is that the smd-edge property $ref could be already defined in a common
"qcom-remoteproc.yaml" schema and inherited via allOf, since all the
qcom remoteprocs should have either a smd-edge or glink-edge.

But all in all I'm still unsure which "common properties" Rob is
referring to here, in which file to place them, and if this is worth it
at all for the few I have listed above... :-)

Thanks,
Stephan