All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 3/4] mpt3sas: Increase cmd_per_lun to 128
Date: Tue, 2 Aug 2022 06:33:41 -0700	[thread overview]
Message-ID: <YukntYR+czw0JnWw@infradead.org> (raw)
In-Reply-To: <CAK=zhgoJJLshCb6VLgo1Htjg1BEw3FXtCJQkJVsAYGQ7Lu0mjw@mail.gmail.com>

On Tue, Aug 02, 2022 at 02:13:42PM +0530, Sreekanth Reddy wrote:
> On Mon, Aug 1, 2022 at 11:28 PM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Mon, Aug 01, 2022 at 06:11:43PM +0530, Sreekanth Reddy wrote:
> > > Increase cmd_per_lun to 128
> >
> > Why?
> 
> In one of the earlier thread (mpt3sas fails to allocate budget_map and
> detects no devices -
> https://lore.kernel.org/all/YdcZwVUFGUPgkbLn@T590/T/) it has been
> mentioned that cmd_per_lun with value 7 is so small and hence we
> thought it is better to increase it to 128.

Well, that is what the commit log is for.  I can see all by myself that
you are increasing it, so you need to explain why.

  reply	other threads:[~2022-08-02 13:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 12:41 [PATCH 0/4] mpt3sas: Few enhancements and fixes Sreekanth Reddy
2022-08-01 12:41 ` [PATCH 1/4] mpt3sas: Don't change dma mask while reallocating pools Sreekanth Reddy
2022-08-01 12:41 ` [PATCH 2/4] mpt3sas: Fix trace buffer registration failed Sreekanth Reddy
2022-08-01 12:41 ` [PATCH 3/4] mpt3sas: Increase cmd_per_lun to 128 Sreekanth Reddy
2022-08-01 17:58   ` Christoph Hellwig
2022-08-02  8:43     ` Sreekanth Reddy
2022-08-02 13:33       ` Christoph Hellwig [this message]
2022-08-01 12:41 ` [PATCH 4/4] mpt3sas: Update driver version to 43.100.00.00 Sreekanth Reddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YukntYR+czw0JnWw@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sreekanth.reddy@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.