Re: [PATCH v4 00/10] adp5588-keys refactor and fw properties support

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-input@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH v4 00/10] adp5588-keys refactor and fw properties support
Date: Tue, 30 Aug 2022 21:19:16 -0700	[thread overview]
Message-ID: <Yw7hRIbsTqOWVeyJ@google.com> (raw)
In-Reply-To: <20220829131553.690063-1-nuno.sa@analog.com>

On Mon, Aug 29, 2022 at 03:15:43PM +0200, Nuno Sá wrote:
> The main goal of this patchset is to remove platform data and replace it by
> firmware properties. Original discussion in [1].
> 
> While in here, some refactor was done to the driver. The most noticeable one
> is to replace the GPIs events handling by irqchip support so that this gpi
> keys can be "consumed" by the gpio-keys driver (also as suggested in [1]).
> With this, the gpio-adp5588 can be removed. This change comes first so that
> we can already remove some platform data variables making it easier to
> completly replace it by firmware properties further down in the series.
> 
> As there's no users of the platform data, I just replace it in a single
> patch as there's no point in having support for both (even though it might
> be harder to review the patch as-is).
> 
> Special note to the gpio-adp5588 driver removal. I'm aware of some changes
> to the driver in [2]. These changes are in the gpio tree and this patchset
> is naturally based on the input tree which means that patch 2 will
> not apply. So, I'm not really sure how to handle this. I guess in this
> case the conflict is easy to handle :) but just let me know on how to
> proceed in here if there's anything for me to do.
> 
> [1]: https://lore.kernel.org/linux-input/20220504084617.36844-1-u.kleine-koenig@pengutronix.de/
> [2]: https://lore.kernel.org/linux-gpio/20220628193906.36350-3-andriy.shevchenko@linux.intel.com/

Given that one of the GPIO maintainers Acked the removal I applied the
series to my tree, thank you.

-- 
Dmitry