Re: [PATCH v13 02/34] media: media-entity.h: add include for min()

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	niklas.soderlund+renesas@ragnatech.se,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Pratyush Yadav <p.yadav@ti.com>,
	Kishon Vijay Abraham <kishon@ti.com>,
	satish.nagireddy@getcruise.com, Tomasz Figa <tfiga@chromium.org>
Subject: Re: [PATCH v13 02/34] media: media-entity.h: add include for min()
Date: Mon, 29 Aug 2022 19:06:49 +0300	[thread overview]
Message-ID: <YwzkGdw0nzHVqnjT@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220810121122.3149086-3-tomi.valkeinen@ideasonboard.com>

Hi Tomi,

Thank you for the patch.

On Wed, Aug 10, 2022 at 03:10:50PM +0300, Tomi Valkeinen wrote:
> ./include/media/media-entity.h:595:34: error: implicit declaration of function ‘min’
> 
> Include kernel.h to get the definition for min().
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
>  include/media/media-entity.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index a9a1c0ec5d1c..3e3d06c1ec36 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -15,6 +15,7 @@
>  #include <linux/bug.h>
>  #include <linux/container_of.h>
>  #include <linux/fwnode.h>
> +#include <linux/kernel.h>

This should be minmax.h. With this fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  #include <linux/list.h>
>  #include <linux/media.h>
>  #include <linux/types.h>

-- 
Regards,

Laurent Pinchart