Re: [PATCH v2 1/2] hv: Use PCI_VENDOR_ID_MICROSOFT for better discoverability

From: Wei Liu <wei.liu@kernel.org>
To: Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: vkuznets@redhat.com, "K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	"open list:Hyper-V/Azure CORE AND DRIVERS" 
	<linux-hyperv@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] hv: Use PCI_VENDOR_ID_MICROSOFT for better discoverability
Date: Mon, 12 Sep 2022 14:53:46 +0000	[thread overview]
Message-ID: <Yx9H+semY705LUkB@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1662749425-3037-2-git-send-email-eahariha@linux.microsoft.com>

On Fri, Sep 09, 2022 at 11:50:24AM -0700, Easwar Hariharan wrote:
> From: Easwar Hariharan <easwar.hariharan@microsoft.com>
> 
> Signed-off-by: Easwar Hariharan <easwar.hariharan@microsoft.com>

> ---
>  drivers/hv/vmbus_drv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 3c833ea..6b77a53 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -39,6 +39,8 @@
>  #include <clocksource/hyperv_timer.h>
>  #include "hyperv_vmbus.h"
>  
> +#define PCI_VENDOR_ID_MICROSOFT 0x1414
> +

There is a patch in hyperv-fixes that puts this definition to a proper
header. You can wait for that to land and rebase this patch.

In the future when you send out a series, please chain all the patches
to a cover letter.

Thanks,
Wei.

>  struct vmbus_dynid {
>  	struct list_head node;
>  	struct hv_vmbus_device_id id;
> @@ -2052,7 +2054,7 @@ struct hv_device *vmbus_device_create(const guid_t *type,
>  	child_device_obj->channel = channel;
>  	guid_copy(&child_device_obj->dev_type, type);
>  	guid_copy(&child_device_obj->dev_instance, instance);
> -	child_device_obj->vendor_id = 0x1414; /* MSFT vendor ID */
> +	child_device_obj->vendor_id = PCI_VENDOR_ID_MICROSOFT;
>  
>  	return child_device_obj;
>  }
> -- 
> 1.8.3.1
> 