From: Nathan Chancellor <nathan@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 0/2] fortify: Add run-time WARN for cross-field memcpy()
Date: Thu, 1 Sep 2022 13:05:23 -0700 [thread overview]
Message-ID: <YxEQg+fOpaPuS/NH@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220901065914.1417829-1-keescook@chromium.org>
Hi Kees,
On Wed, Aug 31, 2022 at 11:59:12PM -0700, Kees Cook wrote:
> Hi,
>
> I'm hoping to at least get this into -next to see how noisy it ends up
> being. I've tracked down several false positives that are getting fixed,
> but I'd like to see this get wider testing. For details, see patch 1,
> but this is the run-time half of the recent FORTIFY_SOURCE memcpy()
> bounds checking work.
>
> -Kees
>
> Kees Cook (2):
> fortify: Add run-time WARN for cross-field memcpy()
> lkdtm: Update tests for memcpy() run-time warnings
>
> drivers/misc/lkdtm/fortify.c | 96 +++++++++++++++++++++----
> include/linux/fortify-string.h | 70 +++++++++++++++++-
> tools/testing/selftests/lkdtm/tests.txt | 8 ++-
> 3 files changed, 155 insertions(+), 19 deletions(-)
>
> --
> 2.34.1
>
I took these two patches for a spin on four of my test machines (one
arm64 and three x86_64, kernel compiled with tip of tree clang) and I
did not see any warnings. Not to say there are not any lurking but my
set of drivers did not appear to trigger anything.
Tested-by: Nathan Chancellor <nathan@kernel.org>
Cheers,
Nathan
prev parent reply other threads:[~2022-09-01 20:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 6:59 [PATCH 0/2] fortify: Add run-time WARN for cross-field memcpy() Kees Cook
2022-09-01 6:59 ` [PATCH 1/2] " Kees Cook
2022-09-07 5:42 ` [fortify] 728833277d: WARNING:at_net/netlink/af_netlink.c:#netlink_ack kernel test robot
2022-09-07 5:42 ` kernel test robot
2022-09-07 7:39 ` Gustavo A. R. Silva
2022-09-07 7:39 ` Gustavo A. R. Silva
2022-09-07 7:49 ` Oliver Sang
2022-09-07 7:49 ` Oliver Sang
2022-09-01 6:59 ` [PATCH 2/2] lkdtm: Update tests for memcpy() run-time warnings Kees Cook
2022-09-01 20:05 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxEQg+fOpaPuS/NH@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.