Re: [PATCH v6 0/3] KVM: selftests: randomize memory access of dirty_log_perf_test

From: David Matlack <dmatlack@google.com>
To: Colton Lewis <coltonlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, maz@kernel.org,
	seanjc@google.com, oupton@google.com, ricarkol@google.com,
	andrew.jones@linux.dev
Subject: Re: [PATCH v6 0/3] KVM: selftests: randomize memory access of dirty_log_perf_test
Date: Mon, 19 Sep 2022 15:36:29 -0700	[thread overview]
Message-ID: <Yyju7VPTgV5NHior@google.com> (raw)
In-Reply-To: <20220912195849.3989707-1-coltonlewis@google.com>

On Mon, Sep 12, 2022 at 07:58:46PM +0000, Colton Lewis wrote:
> Add the ability to randomize parts of dirty_log_perf_test,
> specifically the order pages are accessed and whether pages are read
> or written.
> 
> v6:
> 
> Change default random seed to the constant 0.
> 
> Explain why 100% writes in populate phase, why no random access in
> populate phase, and why use two random numbers in the guest code.
> 
> Colton Lewis (3):
>   KVM: selftests: implement random number generation for guest code
>   KVM: selftests: randomize which pages are written vs read
>   KVM: selftests: randomize page access order

For the whole series:

Reviewed-by: David Matlack <dmatlack@google.com>

> 
>  .../selftests/kvm/access_tracking_perf_test.c |  2 +-
>  .../selftests/kvm/dirty_log_perf_test.c       | 55 ++++++++++++++-----
>  .../selftests/kvm/include/perf_test_util.h    |  8 ++-
>  .../testing/selftests/kvm/include/test_util.h |  2 +
>  .../selftests/kvm/lib/perf_test_util.c        | 39 ++++++++++---
>  tools/testing/selftests/kvm/lib/test_util.c   |  9 +++
>  6 files changed, 90 insertions(+), 25 deletions(-)
> 
> --
> 2.37.2.789.g6183377224-goog