From: Ira Weiny <ira.weiny@intel.com>
To: "J. R. Okajima" <hooanon05g@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH][CFT] [coredump] don't use __kernel_write() on kmap_local_page()
Date: Mon, 3 Oct 2022 12:31:36 -0700 [thread overview]
Message-ID: <Yzs4mL3zrrC0/vN+@iweiny-mobl> (raw)
In-Reply-To: <7714.1664794108@jrobl>
On Mon, Oct 03, 2022 at 07:48:28PM +0900, J. R. Okajima wrote:
> Ira Weiny:
> > On Wed, Sep 28, 2022 at 07:29:43PM +0100, Al Viro wrote:
> > > On Tue, Sep 27, 2022 at 11:51:17PM +0100, Al Viro wrote:
> > > > [I'm going to send a pull request tomorrow if nobody yells;
> > > > please review and test - it seems to work fine here, but extra
> > > > eyes and extra testing would be very welcome]
>
> I tried gdb backtrace 'bt' command with the new core by v6.0, and it
> doesn't show the call trace correctly. Is it related to this commit?
>
Are you also getting something like this?
BFD: warning: /mnt/9p/test-okajima/core is truncated: expected core file size >= 225280, found: 76616
I did not see that before. I'm running through this patch vs a fix to
kmap_to_page()[1] and I may have gotten the 2 crossed up. So I'm retesting
with your test below.
Ira
[1] https://lore.kernel.org/linux-mm/20221003040427.1082050-1-ira.weiny@intel.com/
> test program
> ----------------------------------------
> void f(int n)
> {
> printf("%d\n", n);
> if (!n)
> kill(getpid(), SIGQUIT);
> f(--n);
> }
>
> int main(int argc, char *argv[])
> {
> f(atoi(argv[1]));
> return 0;
> }
> ----------------------------------------
> ulimit -c unlimited
> coredump 2
> gdb coredump core
> bt
> ----------------------------------------
> expected result
> kill
> f
> f
> f
> main
> ----------------------------------------
> actual result
> ??
> ??
> ----------------------------------------
>
>
> J. R. Okajima
next prev parent reply other threads:[~2022-10-03 19:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 22:51 [PATCH][CFT] [coredump] don't use __kernel_write() on kmap_local_page() Al Viro
2022-09-28 17:57 ` Eric W. Biederman
2022-09-28 18:29 ` Al Viro
2022-10-03 3:51 ` Ira Weiny
2022-10-03 10:48 ` J. R. Okajima
2022-10-03 19:31 ` Ira Weiny [this message]
2022-10-03 22:18 ` Al Viro
2022-10-03 22:58 ` J. R. Okajima
2022-10-03 23:37 ` Al Viro
2022-10-04 0:20 ` Linus Torvalds
2022-10-04 0:31 ` Al Viro
2022-10-04 0:37 ` Linus Torvalds
2022-10-04 0:52 ` Al Viro
2022-10-04 6:18 ` Sedat Dilek
2022-10-09 10:37 ` Sedat Dilek
2022-11-09 13:57 ` Geert Uytterhoeven
2022-10-04 2:17 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzs4mL3zrrC0/vN+@iweiny-mobl \
--to=ira.weiny@intel.com \
--cc=hooanon05g@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.