From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, "Ming Lei" <ming.lei@redhat.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Huang Ying" <ying.huang@intel.com>,
"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH v7 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path
Date: Mon, 3 Oct 2022 06:40:50 -1000 [thread overview]
Message-ID: <YzsQkpYOeIfDSA03@slm.duckdns.org> (raw)
In-Reply-To: <20221003154459.207538-3-longman@redhat.com>
On Mon, Oct 03, 2022 at 11:44:58AM -0400, Waiman Long wrote:
> For blkcg_css_alloc(), the only error that will be returned is -ENOMEM.
> Simplify error handling code by returning this error directly instead
> of setting an intermediate "ret" variable.
>
> Signed-off-by: Waiman Long <longman@redhat.com>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2022-10-03 16:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 15:44 [PATCH v7 0/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-10-03 15:44 ` Waiman Long
2022-10-03 15:44 ` [PATCH v7 1/3] llist: Add a lock-less list variant terminated by a sentinel node Waiman Long
2022-10-03 16:40 ` Tejun Heo
2022-10-03 16:40 ` Tejun Heo
2022-10-03 16:55 ` Waiman Long
2022-10-03 16:55 ` Waiman Long
2022-10-03 16:57 ` Tejun Heo
2022-10-03 16:57 ` Tejun Heo
2022-10-03 17:32 ` Waiman Long
2022-10-03 17:32 ` Waiman Long
2022-10-03 17:36 ` Tejun Heo
2022-10-03 17:40 ` Waiman Long
2022-10-03 19:39 ` Waiman Long
2022-10-03 19:39 ` Waiman Long
2022-10-03 20:15 ` Tejun Heo
2022-10-03 20:15 ` Tejun Heo
2022-10-08 2:15 ` Huang, Ying
2022-10-03 15:44 ` [PATCH v7 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Waiman Long
2022-10-03 16:40 ` Tejun Heo [this message]
2022-10-03 15:44 ` [PATCH v7 3/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzsQkpYOeIfDSA03@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.