From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
lorenzo.bianconi@redhat.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhb
Date: Thu, 9 Mar 2023 10:57:00 +0100 [thread overview]
Message-ID: <ZAmtbGfUJiH5gSIY@lore-desk> (raw)
In-Reply-To: <f2bbda1a-b6e3-ccbb-d77a-8bdb42aca0ee@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
On Mar 07, Krzysztof Kozlowski wrote:
> On 06/03/2023 12:08, Lorenzo Bianconi wrote:
> > Add device bindings for asm330lhb IMU sensor.
> > Use asm330lhh as fallback device for asm330lhb since it implements all
> > the features currently supported by asm330lhb.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > index decf022335d8..b39f5217d8ff 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > @@ -46,6 +46,9 @@ properties:
> > - items:
> > - const: st,ism330is
> > - const: st,lsm6dso16is
> > + - items:
> > + - const: st,asm330lhb
> > + - const: st,asm330lhh
>
> You added it to the end of the list, but aren't there any ordering
> already? If so, it should be put rather in correct place.
Hi Krzysztof,
I do not think there is any ordering issue there.
Regards,
Lorenzo
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> Best regards,
> Krzysztof
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-03-09 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 11:07 [PATCH 0/2] add support for ASM330LHB Lorenzo Bianconi
2023-03-06 11:08 ` [PATCH 1/2] iio: imu: st_lsm6dsx: add support to ASM330LHB Lorenzo Bianconi
2023-03-06 11:08 ` [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhb Lorenzo Bianconi
2023-03-07 9:10 ` Krzysztof Kozlowski
2023-03-09 9:57 ` Lorenzo Bianconi [this message]
2023-03-12 15:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAmtbGfUJiH5gSIY@lore-desk \
--to=lorenzo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.