From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: "linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 3/4] fec: add FIXME to move 'mac_managed_pm' to probe
Date: Thu, 16 Mar 2023 14:53:27 +0100 [thread overview]
Message-ID: <ZBMfV2BwiMLyKC7w@ninjato> (raw)
In-Reply-To: <AM5PR04MB313943C24A61C48D761B452688BC9@AM5PR04MB3139.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
> Thank you Wolfram. But I'm not sure whether it's really an issue. The flag
> " mac_managed_pm" indicates that the MAC driver will take care of
> suspending/resuming the PHY, that is to say the MAC driver calls
> phy_stop()/phy_start() in its PM callbacks. If a ethernet interface never
> brings up, the MAC PM callbacks do nothing and just return 0 directly. So I
> think it's fine for the MDIO PM to do suspend/resume the PHY unless the MDIO
> bus can't be accessed.
I have one board here where accessing the MDIO bus times out, although I
don't really understand why. And another one where the call to
phy_init_hw() during resume causes issues. There might be more problems
with these boards, but I think it is cleaner to avoid any MDIO bus
suspend/resume if we have 'mac_managed_pm' anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-03-16 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 13:14 [PATCH net 0/4] net: set 'mac_managed_pm' at probe time Wolfram Sang
2023-03-14 13:14 ` [PATCH net 1/4] ravb: avoid PHY being resumed when interface is not up Wolfram Sang
2023-03-14 13:14 ` [PATCH net 2/4] sh_eth: " Wolfram Sang
2023-03-14 13:14 ` [PATCH net-next 3/4] fec: add FIXME to move 'mac_managed_pm' to probe Wolfram Sang
2023-03-15 5:48 ` Wei Fang
2023-03-15 7:27 ` Wolfram Sang
2023-03-16 8:02 ` Wolfram Sang
2023-03-16 9:10 ` Wei Fang
2023-03-16 13:53 ` Wolfram Sang [this message]
2023-03-14 13:14 ` [PATCH net-next 4/4] smsc911x: " Wolfram Sang
2023-03-15 8:50 ` Geert Uytterhoeven
2023-03-15 8:52 ` Wolfram Sang
2023-03-14 15:56 ` [PATCH net 0/4] net: set 'mac_managed_pm' at probe time Michal Kubiak
2023-03-14 16:40 ` Simon Horman
2023-03-15 7:26 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBMfV2BwiMLyKC7w@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.