Re: [PATCH V3 1/2] mm: compaction: move compact_memory sysctl to its own file

From: Luis Chamberlain <mcgrof@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: ye.xingchen@zte.com.cn, keescook@chromium.org,
	yzaikin@google.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, chi.minghao@zte.com.cn
Subject: Re: [PATCH V3 1/2] mm: compaction: move compact_memory sysctl to its own file
Date: Sun, 19 Mar 2023 13:54:46 -0700	[thread overview]
Message-ID: <ZBd2lhza9JRcFI+8@bombadil.infradead.org> (raw)
In-Reply-To: <17e2a143-37eb-fb4e-d8a9-2d6dc20f9499@suse.cz>

On Thu, Mar 09, 2023 at 10:47:46AM +0100, Vlastimil Babka wrote:
> On 3/9/23 04:44, ye.xingchen@zte.com.cn wrote:
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> > 
> > The compact_memory is part of compaction, move it to its own file.
> > 
> > Link: https://lore.kernel.org/all/ZAJwoXJCzfk1WIBx@bombadil.infradead.org/
> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> > Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> > ---
> >  kernel/sysctl.c |  7 -------
> >  mm/compaction.c | 15 +++++++++++++++
> >  2 files changed, 15 insertions(+), 7 deletions(-)
> > 
> > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > index c14552a662ae..f574f9985df4 100644
> > --- a/kernel/sysctl.c
> > +++ b/kernel/sysctl.c
> > @@ -2190,13 +2190,6 @@ static struct ctl_table vm_table[] = {
> >  		.extra2		= SYSCTL_FOUR,
> >  	},
> >  #ifdef CONFIG_COMPACTION
> > -	{
> > -		.procname	= "compact_memory",
> > -		.data		= NULL,
> > -		.maxlen		= sizeof(int),
> > -		.mode		= 0200,
> > -		.proc_handler	= sysctl_compaction_handler,
> > -	},
> >  	{
> >  		.procname	= "compaction_proactiveness",
> >  		.data		= &sysctl_compaction_proactiveness,
> 
> There's also this one, and two more, please move all of them at once?

I'll wait for a v4, and if you can rebase on top of this tree that would
be appreciated:

https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next

  Luis