From: Helge Deller <deller@gmx.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH fbtest] pnmtohex: Optionally use pkg-config for netpbm
Date: Tue, 28 Mar 2023 14:20:06 +0200 [thread overview]
Message-ID: <ZCLbduJjX0KS/kJx@ls3530> (raw)
In-Reply-To: <20230326104232.3099222-1-geert@linux-m68k.org>
* Geert Uytterhoeven <geert@linux-m68k.org>:
> As of libnetpbm11 in Debian/Ubuntu, the netpbm header files are no
> longer located in the root include directory, but in a netbpm
> subdirectory. Fortunately the same version added support for
> pkg-config.
>
> Support both old and new systems by using pkg-config, when available.
>
> Reported-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Helge: Does this fix the issue for you. I don't have a system with
> libnetpbm11 handy yet.
Yes, thanks a lot!
That fixes the build on parisc on Debian 12.0 for me.
You may add:
Tested-by: Helge Deller <deller@gmx.de>
I tried on my Fedora 36/x86_64 as well, and there netpbm-devel
sadly comes without pkg-config. Nevertheless, based on top of
your patch by hacking in the include path fixed the issue there
as well.
Maybe you can consider applying below patch on top of yours as too?
Helge
---------
[PATCH] Add netpbm to include search patch
Netpbm on Fedora 36 comes without pkg-config, so
manually add the include path.
Signed-off-by: Helge Deller <deller@gmx.de>
---
diff --git a/pnmtohex/Makefile b/pnmtohex/Makefile
index 642a26f..d8925a9 100644
--- a/pnmtohex/Makefile
+++ b/pnmtohex/Makefile
@@ -4,6 +4,7 @@ TOPDIR = ..
HOST_TARGET = pnmtohex
CFLAGS += $(shell pkg-config --exists netpbm && pkg-config --cflags netpbm)
+CFLAGS += -I/usr/include/netpbm
# Modern distro's (e.g. Debian, Fedora Core) seem to have -lnetpbm only
#LIBS += -lnetpnm -lnetpbm -lnetpgm -lnetppm
next prev parent reply other threads:[~2023-03-28 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 10:42 [PATCH fbtest] pnmtohex: Optionally use pkg-config for netpbm Geert Uytterhoeven
2023-03-28 12:20 ` Helge Deller [this message]
2023-04-03 9:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCLbduJjX0KS/kJx@ls3530 \
--to=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.