All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH 0/2] tools/nolibc: fork: fix on s390 and add test
Date: Sun, 16 Apr 2023 07:33:09 +0200	[thread overview]
Message-ID: <ZDuIlQ4mR9Ic116I@1wt.eu> (raw)
In-Reply-To: <20230415-nolibc-fork-v1-0-9747c73651c5@weissschuh.net>

Hi Thomas,

On Sat, Apr 15, 2023 at 11:28:46PM +0200, Thomas Weißschuh wrote:
> The generic fork() implementation in nolibc falls back to the clone()
> syscall. On s390 the first two arguments to clone() are swapped compared
> to other architectures, breaking the implementation in nolibc.
> 
> Add a custom implementation of fork() to s390 that works.
> 
> While at it also add a testcase for fork().
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Thanks for these. Please always Cc the authors of code you're fixing
(e.g. there could be more subtle details that only the author knows
about). Here I think it's OK, but I've CCed Sven and will add him to
your fix.

Thank you!
Willy

      parent reply	other threads:[~2023-04-16  5:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-15 21:28 [PATCH 0/2] tools/nolibc: fork: fix on s390 and add test Thomas Weißschuh
2023-04-15 21:28 ` [PATCH 1/2] tools/nolibc: s390: provide custom implementation for sys_fork Thomas Weißschuh
2023-05-09  7:53   ` Sven Schnelle
2023-04-15 21:28 ` [PATCH 2/2] tools/nolibc: add testcase for fork()/waitpid() Thomas Weißschuh
2023-04-16  5:33 ` Willy Tarreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZDuIlQ4mR9Ic116I@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=shuah@kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.