Re: [PATCH v9 4/5] spi: dw: Add DMA address widths capability check

From: Mark Brown <broonie@kernel.org>
To: Joy Chakraborty <joychakr@google.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	manugautam@google.com, rohitner@google.com
Subject: Re: [PATCH v9 4/5] spi: dw: Add DMA address widths capability check
Date: Mon, 8 May 2023 22:16:50 +0900	[thread overview]
Message-ID: <ZFj2QraXvNqBRwqM@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20230427123314.1997152-5-joychakr@google.com>

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

On Thu, Apr 27, 2023 at 12:33:13PM +0000, Joy Chakraborty wrote:
> Store address width capabilities of DMA controller during init and check
> the same per transfer to make sure the bits/word requirement can be met.
> 
> Current DW DMA driver requires both tx and rx channel to be configured
> and functional hence a subset of both tx and rx channel address width
> capability is checked with the width requirement(n_bytes) for a
> transfer.

This breaks an x86 allmodconfig build:

/build/stage/linux/drivers/spi/spi-dw-dma.c: In function ‘dw_spi_dma_caps_init’:
/build/stage/linux/drivers/spi/spi-dw-dma.c:100:1: error: control reaches end of non-void function [-Werror=return-type]
  100 | }
      | ^
cc1: some warnings being treated as errors

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]