Re: [PATCH RFC net-next v3 6/8] virtio/vsock: support dgrams

From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Simon Horman <simon.horman@corigine.com>,
	Bobby Eshleman <bobby.eshleman@bytedance.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Bryan Tan <bryantan@vmware.com>, Vishnu Dasa <vdasa@vmware.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hyperv@vger.kernel.org
Subject: Re: [PATCH RFC net-next v3 6/8] virtio/vsock: support dgrams
Date: Thu, 1 Jun 2023 07:54:07 +0000	[thread overview]
Message-ID: <ZHhOn7QKdByqc3m+@bullseye> (raw)
In-Reply-To: <d2e9c45f-bcbd-4e6a-98c1-c98283450626@kadam.mountain>

On Wed, May 31, 2023 at 09:13:04PM +0300, Dan Carpenter wrote:
> On Wed, May 31, 2023 at 06:09:11PM +0200, Simon Horman wrote:
> > > @@ -102,6 +144,7 @@ virtio_transport_alloc_skb(struct virtio_vsock_pkt_info *info,
> > 
> > Smatch that err may not be initialised in the out label below.
> > 
> > Just above this context the following appears:
> > 
> > 	if (info->vsk && !skb_set_owner_sk_safe(skb, sk_vsock(info->vsk))) {
> > 		WARN_ONCE(1, "failed to allocate skb on vsock socket with sk_refcnt == 0\n");
> > 		goto out;
> > 	}
> > 
> > So I wonder if in that case err may not be initialised.
> > 
> 
> Yep, exactly right.  I commented out the goto and it silenced the
> warning.  I also initialized err to zero at the start hoping that it
> would trigger a different warning but it didn't.  :(
> 
> regards,
> dan carpenter
> 

Thanks for checking that Dan. Fixed in the next rev.

Best,
Bobby