From: Peter Xu <peterx@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Leonardo Bras <leobras@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test
Date: Thu, 1 Jun 2023 13:04:29 -0400 [thread overview]
Message-ID: <ZHjPnfnOCQpjsbiG@x1n> (raw)
In-Reply-To: <ZHjJGjZKgyaT4EO5@redhat.com>
On Thu, Jun 01, 2023 at 05:36:42PM +0100, Daniel P. Berrangé wrote:
> > The problem is non-live is already not real world usage in most cases. It
> > seems we all agreed that it's the code paths to cover not real world usages
> > in the tests, or maybe not?
>
> The cases that i made run non-live are exercising code paths that
> are only relevant during migration setup, so the non-live vs live
> status is irrelevant to the code coverage attained for those tests.
> Other remaining live tests give sufficient coverage for the live
> scenario
IMHO actually I think it's good we discuss about the goal of target of what
qtest plays a role here, hitting the issue of over-used CI and test running
too long.
For migration tests I'm not sure how Juan sees this I'd say it's good
enough to make it "just to cover code paths as much as possible".
We're never covering real use cases anyway, IMHO, if we start with 128M VM
running sequential dirty workload only. We still need to rely on real
migration tests carried out elsewhere I believe.
So I'd say we're fine to leverage a new parameter especially if the
parameter is simple enough (for logical change I only expect a few LOCs
with switchover-hold) to help us achieve it.
Let's keep that on top anyway, no matter what. Thanks.
--
Peter Xu
next prev parent reply other threads:[~2023-06-01 17:05 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 13:23 [PATCH v3 0/9] tests/qtest: make migration-test massively faster Daniel P. Berrangé
2023-05-31 13:23 ` [PATCH v3 1/9] tests/qtest: add various qtest_qmp_assert_success() variants Daniel P. Berrangé
2023-06-01 9:23 ` Thomas Huth
2023-06-01 12:48 ` Daniel P. Berrangé
2023-06-01 12:04 ` Juan Quintela
2023-06-01 12:20 ` Juan Quintela
2023-06-01 12:51 ` Daniel P. Berrangé
2023-05-31 13:23 ` [PATCH v3 2/9] tests/qtest: add support for callback to receive QMP events Daniel P. Berrangé
2023-05-31 14:57 ` Thomas Huth
2023-06-01 12:14 ` Juan Quintela
2023-06-01 12:56 ` Daniel P. Berrangé
2023-05-31 13:23 ` [PATCH v3 3/9] tests/qtest: get rid of 'qmp_command' helper in migration test Daniel P. Berrangé
2023-06-01 9:26 ` Thomas Huth
2023-06-01 9:32 ` Daniel P. Berrangé
2023-06-01 12:17 ` Juan Quintela
2023-05-31 13:23 ` [PATCH v3 4/9] tests/qtest: get rid of some 'qtest_qmp' usage " Daniel P. Berrangé
2023-06-01 9:28 ` Thomas Huth
2023-06-01 12:10 ` Juan Quintela
2023-05-31 13:23 ` [PATCH v3 5/9] tests/qtest: switch to using event callbacks for STOP event Daniel P. Berrangé
2023-06-01 9:31 ` Thomas Huth
2023-06-01 12:23 ` Juan Quintela
2023-05-31 13:23 ` [PATCH v3 6/9] tests/qtest: replace wait_command() with qtest_qmp_assert_success Daniel P. Berrangé
2023-06-01 9:37 ` Thomas Huth
2023-06-01 12:27 ` Juan Quintela
2023-05-31 13:23 ` [PATCH v3 7/9] tests/qtest: capture RESUME events during migration Daniel P. Berrangé
2023-06-01 9:38 ` Thomas Huth
2023-06-01 12:31 ` Juan Quintela
2023-06-01 12:34 ` Daniel P. Berrangé
2023-06-01 12:37 ` Juan Quintela
2023-06-01 12:44 ` Daniel P. Berrangé
2023-05-31 13:23 ` [PATCH v3 8/9] tests/qtest: make more migration pre-copy scenarios run non-live Daniel P. Berrangé
2023-06-01 9:47 ` Thomas Huth
2023-06-01 12:33 ` Juan Quintela
2023-06-01 12:38 ` Daniel P. Berrangé
2023-06-01 16:09 ` Thomas Huth
2023-06-01 16:17 ` Daniel P. Berrangé
2023-06-01 16:26 ` Peter Xu
2023-06-01 15:30 ` Peter Xu
2023-06-01 15:39 ` Daniel P. Berrangé
2023-06-01 15:53 ` Peter Xu
2023-06-01 15:55 ` Daniel P. Berrangé
2023-06-01 16:17 ` Peter Xu
2023-06-01 16:35 ` Daniel P. Berrangé
2023-06-01 16:59 ` Peter Xu
2023-06-01 22:58 ` Juan Quintela
2023-06-01 22:55 ` Juan Quintela
2023-05-31 13:24 ` [PATCH v3 9/9] tests/qtest: massively speed up migration-test Daniel P. Berrangé
2023-06-01 10:04 ` Thomas Huth
2023-06-01 15:46 ` Peter Xu
2023-06-01 16:05 ` Daniel P. Berrangé
2023-06-01 16:22 ` Peter Xu
2023-06-01 16:36 ` Daniel P. Berrangé
2023-06-01 17:04 ` Peter Xu [this message]
2023-06-01 23:00 ` Juan Quintela
2023-06-01 23:43 ` Peter Xu
2023-07-10 9:35 ` Daniel P. Berrangé
2023-07-10 9:40 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHjPnfnOCQpjsbiG@x1n \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.