From: Matthias Kaehlcke <mka@chromium.org>
To: Benjamin Bara <bbara93@gmail.com>
Cc: benjamin.bara@skidata.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v2 1/3] usb: misc: onboard-hub: support multiple power supplies
Date: Wed, 21 Jun 2023 15:52:15 +0000 [thread overview]
Message-ID: <ZJMcrwcwx5HVC/DL@google.com> (raw)
In-Reply-To: <20230621154505.2229794-1-bbara93@gmail.com>
On Wed, Jun 21, 2023 at 05:45:05PM +0200, Benjamin Bara wrote:
> Hi,
>
> thanks for the feedback!
>
> On Wed, 21 Jun 2023 at 16:57, Matthias Kaehlcke <mka@chromium.org> wrote:
> > On Wed, Jun 21, 2023 at 04:26:27PM +0200, Benjamin Bara wrote:
> > > + hub->supplies_num = 1;
> > > + if (hub->pdata->supplies_num > 1)
> > > + hub->supplies_num = hub->pdata->supplies_num;
> >
> > Please change the above to:
> >
> > if (hub->pdata->supplies_num != 0)
> > hub->supplies_num = hub->pdata->supplies_num;
> > else
> > hub->supplies_num = 1;
> >
>
> I would even prefer:
> if (hub->pdata->supplies_num)
>
> if it's fine for you?
Sounds good to me :)
next prev parent reply other threads:[~2023-06-21 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 14:26 [PATCH v2 0/3] usb: misc: onboard_usb_hub: add support for Cypress HX3 USB 3.0 family Benjamin Bara
2023-06-21 14:26 ` [PATCH v2 1/3] usb: misc: onboard-hub: support multiple power supplies Benjamin Bara
2023-06-21 14:57 ` Matthias Kaehlcke
2023-06-21 15:45 ` Benjamin Bara
2023-06-21 15:52 ` Matthias Kaehlcke [this message]
2023-06-22 5:16 ` Alexander Stein
2023-06-22 5:31 ` Benjamin Bara
2023-06-21 14:26 ` [PATCH v2 2/3] usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family Benjamin Bara
2023-06-21 15:01 ` Matthias Kaehlcke
2023-06-21 14:26 ` [PATCH v2 3/3] dt-bindings: usb: Add binding " Benjamin Bara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJMcrwcwx5HVC/DL@google.com \
--to=mka@chromium.org \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.