From: Matthias Kaehlcke <mka@chromium.org>
To: Benjamin Bara <bbara93@gmail.com>
Cc: lkp@intel.com, alexander.stein@ew.tq-group.com,
benjamin.bara@skidata.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
krzk@kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
robh+dt@kernel.org
Subject: Re: [PATCH v5 1/3] usb: misc: onboard-hub: support multiple power supplies
Date: Thu, 22 Jun 2023 16:08:55 +0000 [thread overview]
Message-ID: <ZJRyF45Ui5U4FraP@google.com> (raw)
In-Reply-To: <20230622102601.2244054-1-bbara93@gmail.com>
On Thu, Jun 22, 2023 at 12:26:01PM +0200, Benjamin Bara wrote:
> On Thu, 22 Jun 2023 at 11:29, kernel test robot <lkp@intel.com> wrote:
> >
> > Hi Benjamin,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on 45a3e24f65e90a047bef86f927ebdc4c710edaa1]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Bara/usb-misc-onboard-hub-support-multiple-power-supplies/20230622-161859
> > base: 45a3e24f65e90a047bef86f927ebdc4c710edaa1
> > patch link: https://lore.kernel.org/r/20230620-hx3-v5-1-319c9c4c846f%40skidata.com
> > patch subject: [PATCH v5 1/3] usb: misc: onboard-hub: support multiple power supplies
> > config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230622/202306221742.xnLvAlnW-lkp@intel.com/config)
> > compiler: alpha-linux-gcc (GCC) 12.3.0
> > reproduce: (https://download.01.org/0day-ci/archive/20230622/202306221742.xnLvAlnW-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202306221742.xnLvAlnW-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/usb/misc/onboard_usb_hub.c: In function 'onboard_hub_probe':
> > >> drivers/usb/misc/onboard_usb_hub.c:262:58: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
> > 262 | return dev_err_probe(dev, -EINVAL, "max %d supplies supported!\n",
> > | ~^
> > | |
> > | int
> > | %ld
>
> Thanks Mr. Robot, seems like I forgot to compile with Werr :/
> I will wait for other feedback and fix this in the next round.
The patch looks good to me with the above fixed.
next prev parent reply other threads:[~2023-06-22 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 8:17 [PATCH v5 0/3] usb: misc: onboard_usb_hub: add support for Cypress HX3 USB 3.0 family Benjamin Bara
2023-06-22 8:17 ` [PATCH v5 1/3] usb: misc: onboard-hub: support multiple power supplies Benjamin Bara
2023-06-22 9:29 ` kernel test robot
2023-06-22 10:26 ` Benjamin Bara
2023-06-22 16:08 ` Matthias Kaehlcke [this message]
2023-06-22 8:17 ` [PATCH v5 2/3] usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family Benjamin Bara
2023-06-22 8:17 ` [PATCH v5 3/3] dt-bindings: usb: Add binding " Benjamin Bara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJRyF45Ui5U4FraP@google.com \
--to=mka@chromium.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.