Re: [cip-dev] [PATCH 5.10.y-cip] usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error

From: Pavel Machek <pavel@denx.de>
To: nobuhiro1.iwamatsu@toshiba.co.jp
Cc: cip-dev@lists.cip-project.org, biju.das.jz@bp.renesas.com,
	pavel@denx.de, fabrizio.castro.jz@renesas.com
Subject: Re: [cip-dev] [PATCH 5.10.y-cip] usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error
Date: Fri, 7 Jul 2023 17:35:51 +0200	[thread overview]
Message-ID: <ZKgw16/ePAKx/1FB@duo.ucw.cz> (raw)
In-Reply-To: <TYWPR01MB94208D921A8950BC0A3CD6FD922CA@TYWPR01MB9420.jpnprd01.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

Hi!

> > > Currently {modprobe, bind} after {rmmod, unbind} results in probe failure.
> > >
> > > genirq: Flags mismatch irq 22. 00000004 (85070400.usb3drd) vs.
> > > 00000004
> > > (85070400.usb3drd)
> > > renesas_usb3: probe of 85070000.usb3peri failed with error -16
> > >
> > > The reason is, it is trying to register an interrupt handler for the same IRQ
> > twice.
> > > The devm_request_irq() was called with the parent device.
> > > So the interrupt handler won't be unregistered when the usb3-peri
> > > device is unbound.
> > >
> > > Fix this issue by replacing "parent dev"->"dev" as the irq resource is
> > > managed by this driver.

> > I reviewed this series. Looks fine to me.
> > I can apply, if there are no comments and issues.
> > 
> > Test:
> > https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919946031
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > 
> Applied, thanks.

Looks ok to me, too.

Thanks and best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]