From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Ruihong Luo" <colorsu1922@gmail.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
stable@vger.kernel.org, luoruihong@xiaomi.com,
weipengliang@xiaomi.com, wengjinfei@xiaomi.com
Subject: Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF register
Date: Wed, 26 Jul 2023 17:42:00 +0300 [thread overview]
Message-ID: <ZMEwuMLQlwABZeRo@smile.fi.intel.com> (raw)
In-Reply-To: <2023072546-ladies-landlord-8a6d@gregkh>
On Tue, Jul 25, 2023 at 08:31:17PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jul 14, 2023 at 03:31:11PM +0300, Andy Shevchenko wrote:
> > On Fri, Jul 14, 2023 at 03:07:42PM +0300, Ilpo Järvinen wrote:
> > > On Thu, 13 Jul 2023, Ruihong Luo wrote:
> > >
> > > > Preserve the original value of the Divisor Latch Fraction (DLF) register.
> > > > When the DLF register is modified without preservation, it can disrupt
> > > > the baudrate settings established by firmware or bootloader, leading to
> > > > data corruption and the generation of unreadable or distorted characters.
> > > >
> > > > Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> >
> > > You forgot to add:
> > >
> > > Cc: stable@vger.kernel.org
> >
> > It's there. Just not in the commit message. It's fine.
>
> No it isn't, that's not how to have a patch added to the stable tree, as
> my form letter says:
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>
>
> I'll go fix it up by hand...
Good to know, thank you for the clarification!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-07-26 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 0:42 [PATCH v4] serial: 8250_dw: Preserve original value of DLF register Ruihong Luo
2023-07-13 0:44 ` kernel test robot
2023-07-13 16:51 ` Andy Shevchenko
2023-07-14 12:07 ` Ilpo Järvinen
2023-07-14 12:31 ` Andy Shevchenko
2023-07-25 18:31 ` Greg Kroah-Hartman
2023-07-26 14:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMEwuMLQlwABZeRo@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=colorsu1922@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luoruihong@xiaomi.com \
--cc=stable@vger.kernel.org \
--cc=weipengliang@xiaomi.com \
--cc=wengjinfei@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.