From: Luis Chamberlain <mcgrof@kernel.org> To: Joel Granados <j.granados@samsung.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>, Kees Cook <keescook@chromium.org>, Iurii Zaikin <yzaikin@google.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, willy@infradead.org, josh@joshtriplett.org, Christian Borntraeger <borntraeger@linux.ibm.com>, Sven Schnelle <svens@linux.ibm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 06/14] sysctl: Add size to register_sysctl Date: Thu, 27 Jul 2023 08:42:02 -0700 [thread overview] Message-ID: <ZMKQSqeKNcJCqkDB@bombadil.infradead.org> (raw) In-Reply-To: <20230727122200.r5o2mj5qgah5yfwm@localhost> On Thu, Jul 27, 2023 at 02:22:00PM +0200, Joel Granados wrote: > On Wed, Jul 26, 2023 at 10:58:30AM -0700, Luis Chamberlain wrote: > > On Wed, Jul 26, 2023 at 04:06:26PM +0200, Joel Granados wrote: > > > In order to remove the end element from the ctl_table struct arrays, we > > > replace the register_syctl function with a macro that will add the > > > ARRAY_SIZE to the new register_sysctl_sz function. In this way the > > > callers that are already using an array of ctl_table structs do not have > > > to change. We *do* change the callers that pass the ctl_table array as a > > > pointer. > > > > Thanks for doing this and this series! > > > > > Signed-off-by: Joel Granados <j.granados@samsung.com> > > > --- > > > diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h > > > index 0495c858989f..b1168ae281c9 100644 > > > --- a/include/linux/sysctl.h > > > +++ b/include/linux/sysctl.h > > > @@ -215,6 +215,9 @@ struct ctl_path { > > > const char *procname; > > > }; > > > > > > +#define register_sysctl(path, table) \ > > > + register_sysctl_sz(path, table, ARRAY_SIZE(table)) > > > + > > > #ifdef CONFIG_SYSCTL > > > > Wasn't it Greg who had suggested this? Maybe add Suggested-by with him > > on it. > Yes. I mentioned him in the cover letter and did not add the tag because > I had not asked for permission to use it. I'll drop him a mail and > include the suggested-by if he agrees. FWIW, I never ask, if they ask for it, clearly they suggested it. > > Also, your cover letter and first few patches are not CC'd to the netdev > > list or others. What you want to do is collect all the email addresses > > for this small patch series and add them to who you email for your > > entire series, otherwise at times they won't be able to properly review > > or understand the exact context of the changes. You want folks to do less > > work to review, not more. > Here I wanted to avoid very big e-mail headers as I have received > rejections from lists in the past. But I for this set, the number of > e-mails is ok to just include everyone. I hear that from time to time, if you have issues with adding folks on the To address it may be an SMTP server issue, ie, corp email SMTP server issues. To fix that I avoid corp email SMTP servers. Luis _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org> To: Joel Granados <j.granados@samsung.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>, Kees Cook <keescook@chromium.org>, Iurii Zaikin <yzaikin@google.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, willy@infradead.org, josh@joshtriplett.org, Christian Borntraeger <borntraeger@linux.ibm.com>, Sven Schnelle <svens@linux.ibm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 06/14] sysctl: Add size to register_sysctl Date: Thu, 27 Jul 2023 08:42:02 -0700 [thread overview] Message-ID: <ZMKQSqeKNcJCqkDB@bombadil.infradead.org> (raw) In-Reply-To: <20230727122200.r5o2mj5qgah5yfwm@localhost> On Thu, Jul 27, 2023 at 02:22:00PM +0200, Joel Granados wrote: > On Wed, Jul 26, 2023 at 10:58:30AM -0700, Luis Chamberlain wrote: > > On Wed, Jul 26, 2023 at 04:06:26PM +0200, Joel Granados wrote: > > > In order to remove the end element from the ctl_table struct arrays, we > > > replace the register_syctl function with a macro that will add the > > > ARRAY_SIZE to the new register_sysctl_sz function. In this way the > > > callers that are already using an array of ctl_table structs do not have > > > to change. We *do* change the callers that pass the ctl_table array as a > > > pointer. > > > > Thanks for doing this and this series! > > > > > Signed-off-by: Joel Granados <j.granados@samsung.com> > > > --- > > > diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h > > > index 0495c858989f..b1168ae281c9 100644 > > > --- a/include/linux/sysctl.h > > > +++ b/include/linux/sysctl.h > > > @@ -215,6 +215,9 @@ struct ctl_path { > > > const char *procname; > > > }; > > > > > > +#define register_sysctl(path, table) \ > > > + register_sysctl_sz(path, table, ARRAY_SIZE(table)) > > > + > > > #ifdef CONFIG_SYSCTL > > > > Wasn't it Greg who had suggested this? Maybe add Suggested-by with him > > on it. > Yes. I mentioned him in the cover letter and did not add the tag because > I had not asked for permission to use it. I'll drop him a mail and > include the suggested-by if he agrees. FWIW, I never ask, if they ask for it, clearly they suggested it. > > Also, your cover letter and first few patches are not CC'd to the netdev > > list or others. What you want to do is collect all the email addresses > > for this small patch series and add them to who you email for your > > entire series, otherwise at times they won't be able to properly review > > or understand the exact context of the changes. You want folks to do less > > work to review, not more. > Here I wanted to avoid very big e-mail headers as I have received > rejections from lists in the past. But I for this set, the number of > e-mails is ok to just include everyone. I hear that from time to time, if you have issues with adding folks on the To address it may be an SMTP server issue, ie, corp email SMTP server issues. To fix that I avoid corp email SMTP servers. Luis
next prev parent reply other threads:[~2023-07-27 15:42 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20230726140648eucas1p29a92c80fb28550e2087cd0ae190d29bd@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 00/14] sysctl: Add a size argument to register functions in sysctl Joel Granados [not found] ` <CGME20230726140650eucas1p1f5b2aa9dd8f90989c881f0a2e682b9eb@eucas1p1.samsung.com> 2023-07-26 14:06 ` [PATCH 01/14] sysctl: Prefer ctl_table_header in proc_sysctl Joel Granados [not found] ` <CGME20230726140652eucas1p2a2ac2dd74986bd9ace8380d6f51024ff@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 02/14] sysctl: Use ctl_table_header in list_for_each_table_entry Joel Granados [not found] ` <CGME20230726140653eucas1p2e234b7cd0af5dc506bd27399b84292a6@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 03/14] sysctl: Add ctl_table_size to ctl_table_header Joel Granados 2023-07-28 10:48 ` Simon Horman 2023-07-31 12:10 ` Joel Granados [not found] ` <CGME20230726140655eucas1p1c71c8de9edc8441b5262c936731b91a2@eucas1p1.samsung.com> 2023-07-26 14:06 ` [PATCH 04/14] sysctl: Add size argument to init_header Joel Granados [not found] ` <CGME20230726140656eucas1p26cd9da21663d25b51dda75258aaa3b55@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 05/14] sysctl: Add a size arg to __register_sysctl_table Joel Granados 2023-07-28 10:51 ` Simon Horman 2023-07-28 16:08 ` Joel Granados [not found] ` <CGME20230726140659eucas1p2c3cd9f57dd13c71ddeb78d2480587e72@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 06/14] sysctl: Add size to register_sysctl Joel Granados 2023-07-26 17:58 ` Luis Chamberlain 2023-07-27 12:22 ` Joel Granados 2023-07-27 12:22 ` Joel Granados 2023-07-27 15:42 ` Luis Chamberlain [this message] 2023-07-27 15:42 ` Luis Chamberlain 2023-07-28 7:41 ` Joel Granados 2023-07-28 7:41 ` Joel Granados [not found] ` <CGME20230726140700eucas1p1e6b16e884362ebec50f6712b3f11a533@eucas1p1.samsung.com> 2023-07-26 14:06 ` [PATCH 07/14] sysctl: Add size arg to __register_sysctl_init Joel Granados 2023-07-28 10:56 ` Simon Horman 2023-07-28 16:11 ` Joel Granados [not found] ` <CGME20230726140702eucas1p20c75fc21d675ea267dd2ad4ebd6e60b4@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 08/14] sysctl: Add size to register_net_sysctl function Joel Granados [not found] ` <CGME20230726140703eucas1p2786577bcc67d5ae434671dac11870c60@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 09/14] ax.25: Update to register_net_sysctl_sz Joel Granados 2023-07-26 18:00 ` Luis Chamberlain 2023-07-27 12:31 ` Joel Granados 2023-07-27 12:31 ` Joel Granados 2023-07-27 15:44 ` Luis Chamberlain 2023-07-28 7:35 ` Joel Granados 2023-07-28 7:35 ` Joel Granados 2023-07-28 18:16 ` Luis Chamberlain 2023-07-31 7:09 ` Joel Granados 2023-07-31 7:09 ` Joel Granados 2023-07-27 15:38 ` Joel Granados 2023-07-27 15:38 ` Joel Granados 2023-07-27 15:50 ` Luis Chamberlain [not found] ` <CGME20230726140706eucas1p1b11e5f0bd17f0de19af9608cbd8d17f3@eucas1p1.samsung.com> 2023-07-26 14:06 ` [PATCH 10/14] netfilter: " Joel Granados 2023-07-26 14:06 ` [Bridge] " Joel Granados 2023-07-26 18:01 ` Luis Chamberlain 2023-07-26 18:01 ` [Bridge] " Luis Chamberlain [not found] ` <CGME20230726140709eucas1p2033d64aec69a1962fd7e64c57ad60adc@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 11/14] networking: " Joel Granados 2023-07-26 18:05 ` Luis Chamberlain 2023-07-27 0:33 ` David Ahern 2023-07-27 12:33 ` Joel Granados 2023-07-28 7:08 ` Joel Granados [not found] ` <CGME20230726140711eucas1p25a947afeef5593e21578f778355db192@eucas1p2.samsung.com> 2023-07-26 14:06 ` [PATCH 12/14] vrf: " Joel Granados [not found] ` <CGME20230726140712eucas1p1bc7b2d150482936d974ceba9c51d7bc4@eucas1p1.samsung.com> 2023-07-26 14:06 ` [PATCH 13/14] sysctl: SIZE_MAX->ARRAY_SIZE in register_net_sysctl Joel Granados [not found] ` <CGME20230726140714eucas1p186bad44daf14c4c8c93f9aaf52deade5@eucas1p1.samsung.com> 2023-07-26 14:06 ` [PATCH 14/14] sysctl: Use size as stopping criteria for list macro Joel Granados 2023-07-26 18:15 ` [PATCH 00/14] sysctl: Add a size argument to register functions in sysctl Luis Chamberlain 2023-07-27 11:43 ` Joel Granados 2023-07-27 15:39 ` Luis Chamberlain 2023-07-28 7:04 ` Joel Granados
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZMKQSqeKNcJCqkDB@bombadil.infradead.org \ --to=mcgrof@kernel.org \ --cc=agordeev@linux.ibm.com \ --cc=borntraeger@linux.ibm.com \ --cc=catalin.marinas@arm.com \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=gor@linux.ibm.com \ --cc=gregkh@linuxfoundation.org \ --cc=hca@linux.ibm.com \ --cc=j.granados@samsung.com \ --cc=josh@joshtriplett.org \ --cc=keescook@chromium.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=svens@linux.ibm.com \ --cc=will@kernel.org \ --cc=willy@infradead.org \ --cc=yzaikin@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.