From: Sean Christopherson <seanjc@google.com>
To: Jinrong Liang <ljr.kernel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
Jim Mattson <jmattson@google.com>, Shuah Khan <shuah@kernel.org>,
Aaron Lewis <aaronlewis@google.com>,
David Matlack <dmatlack@google.com>,
Vishal Annapurve <vannapurve@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Like Xu <like.xu.linux@gmail.com>,
Jinrong Liang <cloudliang@tencent.com>,
linux-kselftest@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/6] KVM: selftests: Introduce __kvm_pmu_event_filter to improved event filter settings
Date: Thu, 17 Aug 2023 13:53:31 -0700 [thread overview]
Message-ID: <ZN6Iy1h6wuiSDZZx@google.com> (raw)
In-Reply-To: <20230810090945.16053-4-cloudliang@tencent.com>
On Thu, Aug 10, 2023, Jinrong Liang wrote:
> -static int run_filter_test(struct kvm_vcpu *vcpu, const uint64_t *events,
> - int nevents, uint32_t flags)
> +static int do_vcpu_set_pmu_event_filter(struct kvm_vcpu *vcpu,
> + struct __kvm_pmu_event_filter *__f)
Just "set_pmu_event_filter()" please. The "do" is pointless, and the "vcpu" part
is confusing since the filter is per-VM, the selftest just happens to pass around
the vCPU. And to be consistent with set_pmu_single_event_filter().
No need for a new version, I'll fixup when applying.
next prev parent reply other threads:[~2023-08-17 20:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 9:09 [PATCH v6 0/6] KVM: selftests: Improve PMU event filter settings and add test cases Jinrong Liang
2023-08-10 9:09 ` [PATCH v6 1/6] KVM: selftests: Add x86 properties for Intel PMU in processor.h Jinrong Liang
2023-08-10 9:09 ` [PATCH v6 2/6] KVM: selftests: Drop the return of remove_event() Jinrong Liang
2023-08-10 9:09 ` [PATCH v6 3/6] KVM: selftests: Introduce __kvm_pmu_event_filter to improved event filter settings Jinrong Liang
2023-08-11 3:09 ` JinrongLiang
2023-08-14 23:49 ` Isaku Yamahata
2023-08-15 3:41 ` Jinrong Liang
2023-08-17 20:17 ` Sean Christopherson
2023-08-17 20:53 ` Sean Christopherson [this message]
2023-08-10 9:09 ` [PATCH v6 4/6] KVM: selftests: Add test cases for unsupported PMU event filter input values Jinrong Liang
2023-08-14 23:51 ` Isaku Yamahata
2023-08-10 9:09 ` [PATCH v6 5/6] KVM: selftests: Test if event filter meets expectations on fixed counters Jinrong Liang
2023-08-15 0:07 ` Isaku Yamahata
2023-08-10 9:09 ` [PATCH v6 6/6] KVM: selftests: Test gp event filters don't affect fixed event filters Jinrong Liang
2023-08-18 0:12 ` [PATCH v6 0/6] KVM: selftests: Improve PMU event filter settings and add test cases Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN6Iy1h6wuiSDZZx@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=cloudliang@tencent.com \
--cc=dmatlack@google.com \
--cc=isaku.yamahata@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ljr.kernel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=vannapurve@google.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.