From: Simon Horman <horms@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Piotr Gardocki <piotrx.gardocki@intel.com>,
Rafal Romanowski <rafal.romanowski@intel.com>
Subject: Re: [PATCH net] iavf: fix potential races for FDIR filters
Date: Tue, 8 Aug 2023 22:14:59 +0200 [thread overview]
Message-ID: <ZNKiQ9vcjNQRfieN@vergenet.net> (raw)
In-Reply-To: <20230807205011.3129224-1-anthony.l.nguyen@intel.com>
On Mon, Aug 07, 2023 at 01:50:11PM -0700, Tony Nguyen wrote:
> From: Piotr Gardocki <piotrx.gardocki@intel.com>
>
> Add fdir_fltr_lock locking in unprotected places.
>
> The change in iavf_fdir_is_dup_fltr adds a spinlock around a loop which
> iterates over all filters and looks for a duplicate. The filter can be
> removed from list and freed from memory at the same time it's being
> compared. All other places where filters are deleted are already
> protected with spinlock.
>
> The remaining changes protect adapter->fdir_active_fltr variable so now
> all its uses are under a spinlock.
>
> Fixes: 527691bf0682 ("iavf: Support IPv4 Flow Director filters")
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-08-08 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 20:50 [PATCH net] iavf: fix potential races for FDIR filters Tony Nguyen
2023-08-08 20:14 ` Simon Horman [this message]
2023-08-08 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNKiQ9vcjNQRfieN@vergenet.net \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotrx.gardocki@intel.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.